openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

ETCD-580: Decrease validity period to prevent cert expiry for offline clusters #1238

Closed hasbro17 closed 7 months ago

hasbro17 commented 7 months ago

Addresses https://issues.redhat.com/browse/ETCD-580 to leave enough time on the cert before it is expired in the event the cluster is shutdown/hibernated for 9 months.

This helps prevent etcd certs from becoming expired while the cluster is offline for extended periods.

/cc @tjungblu

openshift-ci-robot commented 7 months ago

@hasbro17: This pull request references ETCD-580 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1238): >Addresses https://issues.redhat.com/browse/ETCD-580 to leave enough time on the cert before it is expired in the event the cluster is shutdown/hibernated for 9 months. > >This helps prevent etcd certs from becoming expired while the cluster is offline for extended periods. > >/cc @tjungblu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 7 months ago

/lgtm

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [hasbro17,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD 3d5483e1871ba147a692736c71645175a85769c4 and 2 for PR HEAD 26f9f705539dc1591e1c0e078f06703f0fc494df in total

tjungblu commented 7 months ago

/override ci/prow/e2e-operator-fips

unrelated OLM failure

openshift-ci[bot] commented 7 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-operator-fips

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1238#issuecomment-2044806783): >/override ci/prow/e2e-operator-fips > >unrelated OLM failure Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 7 months ago

@hasbro17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-qe-no-capabilities 26f9f705539dc1591e1c0e078f06703f0fc494df link false /test e2e-gcp-qe-no-capabilities

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.16.0-202404091010.p0.g9c525f6.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.