search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

OCPBUGS-31849: check the quorum in case the cluster is healthy or not after generating certs #1239

Closed lance5890 closed 6 months ago

lance5890 commented 7 months ago

address https://github.com/openshift/cluster-etcd-operator/issues/1240 and https://github.com/openshift/cluster-etcd-operator/issues/1237

openshift-ci[bot] commented 7 months ago

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
lance5890 commented 7 months ago

/cc @tjungblu

openshift-ci-robot commented 7 months ago

@lance5890: This pull request references Jira Issue OCPBUGS-31849, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1239): >address https://github.com/openshift/cluster-etcd-operator/issues/1240 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 7 months ago

/ok-to-test

tjungblu commented 7 months ago

we're mostly done for the 4.16 cert stuff, I'll check this out tomorrow in depth again @lance5890

tjungblu commented 7 months ago

/retest

tjungblu commented 7 months ago

/test all

tjungblu commented 7 months ago

I'm so free to already run the blocking payloads, the unit test failures are expected given the removal of the statements

/payload 4.16 nightly blocking

openshift-ci[bot] commented 7 months ago

@tjungblu: trigger 8 job(s) of type blocking for the nightly release of OCP 4.16

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/82e77220-fccf-11ee-8b38-ace81943d6db-0

tjungblu commented 7 months ago

/retest

tjungblu commented 7 months ago

besides Azure, the bare metal jobs report bootstrap issues: https://pr-payload-tests.ci.openshift.org/runs/ci/82e77220-fccf-11ee-8b38-ace81943d6db-0

I'll take a look in a bit, brb

tjungblu commented 7 months ago

/payload 4.16 nightly blocking

trying again, the failures don't make a whole lot of sense to me. One run does have neither the installer bundle nor the must-gather. The other run it seems there's a whole machine entirely missing.

tjungblu commented 7 months ago

/test ?

openshift-ci[bot] commented 7 months ago

@tjungblu: trigger 8 job(s) of type blocking for the nightly release of OCP 4.16

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1216c6a0-fd69-11ee-9891-7fb7bf49abc9-0

openshift-ci[bot] commented 7 months ago

@tjungblu: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1239#issuecomment-2063474256): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tjungblu commented 7 months ago

/test e2e-metal-assisted /test e2e-metal-ipi-ovn-ipv6

tjungblu commented 7 months ago

/test e2e-metal-single-node-live-iso

lance5890 commented 7 months ago

/retest

lance5890 commented 6 months ago

/test e2e-metal-single-node-live-iso

should we move forward this ?

tjungblu commented 6 months ago

I'm cool with merging this, we need to see how we can backport this potentially. But let's get this into 4.16 for now, we should have some more time to see if any regressions pop up. Thanks a lot @lance5890

/lgtm

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance5890, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tjungblu commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@tjungblu: This pull request references Jira Issue OCPBUGS-31849, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1239#issuecomment-2095342607): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 6 months ago

/override ci/prow/e2e-operator-fips

openshift-ci[bot] commented 6 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-operator-fips

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1239#issuecomment-2095343023): >/override ci/prow/e2e-operator-fips > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 6 months ago

/retest-required

Remaining retests: 0 against base HEAD cb78ee25cda56d8f2deb4f0e4ed09348d07220f8 and 2 for PR HEAD 17e51532d089bddc202717f7991708245d2b5509 in total

lance5890 commented 6 months ago

/retest

lance5890 commented 6 months ago

/test e2e-aws-ovn-single-node

openshift-ci[bot] commented 6 months ago

@lance5890: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-qe-no-capabilities 17e51532d089bddc202717f7991708245d2b5509 link false /test e2e-gcp-qe-no-capabilities

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 6 months ago

@lance5890: Jira Issue OCPBUGS-31849: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31849 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1239): >address https://github.com/openshift/cluster-etcd-operator/issues/1240 and https://github.com/openshift/cluster-etcd-operator/issues/1237 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202405070919.p0.gfe27bae.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.

openshift-merge-robot commented 6 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-05-08-222442