search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

ETCD-519:Add reconcile etcd database size #1248

Closed Elbehery closed 6 months ago

Elbehery commented 7 months ago

resolves https://issues.redhat.com/browse/ETCD-519

cc @tjungblu @dusk125 @hasbro17 @soltysh

suppresses https://github.com/openshift/cluster-etcd-operator/pull/1184

openshift-ci-robot commented 7 months ago

@Elbehery: This pull request references ETCD-519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1248): >resolves https://issues.redhat.com/browse/ETCD-519 > >cc @tjungblu @dusk125 @hasbro17 @soltysh > >suppresses https://github.com/openshift/cluster-etcd-operator/pull/1184 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Elbehery commented 7 months ago

/jira refresh

openshift-ci-robot commented 7 months ago

@Elbehery: This pull request references ETCD-519 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1248#issuecomment-2063833079): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Elbehery commented 6 months ago

/label tide/merge-method-squash

Elbehery commented 6 months ago

/test e2e-operator-fips

Elbehery commented 6 months ago

/test e2e-operator-fips

Elbehery commented 6 months ago

/test e2e-operator-fips

Elbehery commented 6 months ago

is failing since 29 Feb 2024 , find job history

actually the job's cluster is never successful, more over the job run an upgrade and this feature is TechPreviewNoUpgrade

Elbehery commented 6 months ago

/override ci/prow/e2e-operator-fips

openshift-ci[bot] commented 6 months ago

@Elbehery: Overrode contexts on behalf of Elbehery: ci/prow/e2e-operator-fips

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1248#issuecomment-2094145357): > >/override ci/prow/e2e-operator-fips > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Elbehery commented 6 months ago

/assign @hasbro17 /assign @tjungblu /assign @dusk125 /assign @soltysh

Elbehery commented 6 months ago

/override ci/prow/e2e-operator-fips

openshift-ci[bot] commented 6 months ago

@Elbehery: Overrode contexts on behalf of Elbehery: ci/prow/e2e-operator-fips

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1248#issuecomment-2094220155): >/override ci/prow/e2e-operator-fips Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Elbehery commented 6 months ago

e2e-operator-fips fails perma since Feb 29 2024

see Job History

see this PR

Elbehery commented 6 months ago

e2e-gcp-qe-no-capabilities fails perma since it was initially created

see Job History

see this PR

Elbehery commented 6 months ago

/override ci/prow/e2e-gcp-qe-no-capabilities

openshift-ci[bot] commented 6 months ago

@Elbehery: Overrode contexts on behalf of Elbehery: ci/prow/e2e-gcp-qe-no-capabilities

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1248#issuecomment-2094221473): >/override ci/prow/e2e-gcp-qe-no-capabilities Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tjungblu commented 6 months ago

looks good to me! Let's wait for Allen/Haseeb for any other comments

Elbehery commented 6 months ago

/retest-required

Elbehery commented 6 months ago

/test ci/prow/e2e-operator

openshift-ci[bot] commented 6 months ago

@Elbehery: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1248#issuecomment-2096310473): >/test ci/prow/e2e-operator > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Elbehery commented 6 months ago

/test e2e-operator

tjungblu commented 6 months ago

I think this was a little too early to retest, but we have to wait for another hour now anyway :p

Elbehery commented 6 months ago

/test e2e-operator

Elbehery commented 6 months ago

featureGate is not enabled yet link

tjungblu commented 6 months ago

/retest

Elbehery commented 6 months ago

this run has the featureGates on link 👍🏽

Elbehery commented 6 months ago

so this last run had the featureGates enabled link

Prow job

I am creating a cluster to debug manually before re-testing 👍🏽

Elbehery commented 6 months ago

@tjungblu i found the issue :)

WaitForPodsToStabilizeOnTheSameRevision() does not wait for the new revision, it asserts on the current revision

I executed the test manually against a TP cluster, and featuregates are on, yet the test failed

debugging it, found that the assertion takes place on the old revision, not the new revision

I am raising a fix now 👍🏽

Elbehery commented 6 months ago

here you go https://github.com/openshift/library-go/pull/1733

cc @tjungblu @lance5890

Elbehery commented 6 months ago

/test e2e-aws-ovn-etcd-scaling

tjungblu commented 6 months ago

/lgtm

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 6 months ago

/retest-required

Remaining retests: 0 against base HEAD fe27bae2b3d834607e679d0628f4f2e3c71acc5a and 2 for PR HEAD 47a637b25678cda78fdfcf9989a1a4679430c411 in total

openshift-ci[bot] commented 6 months ago

@Elbehery: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-qe-no-capabilities 47a637b25678cda78fdfcf9989a1a4679430c411 link false /test e2e-gcp-qe-no-capabilities

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.16.0-202405071820.p0.gcbfb856.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.