ETCD-583: add signer expiration metric and alert

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster

Apache License 2.0

96 stars 130 forks source link

ETCD-583: add signer expiration metric and alert #1249

Closed tjungblu closed 7 months ago

tjungblu commented 7 months ago

/hold

need to add an alert as well

openshift-ci-robot commented 7 months ago

@tjungblu: This pull request references ETCD-583 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1249): >/hold > >need to add an alert as well Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

tjungblu commented 7 months ago

/hold cancel

good to review

tjungblu commented 7 months ago

alerts will look like this:

not sure if we can round the integer somehow, otherwise that's doing the job - provided we agree on the thresholds edit: added formatting as integer

hasbro17 commented 7 months ago

/lgtm /retest-required

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [hasbro17,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD 635c23a054e917830a15d6031734a384db7770b4 and 2 for PR HEAD 89aaf6ed6649ddd5356a48ae0d00380158026d5a in total

tjungblu commented 7 months ago

/override ci/prow/e2e-operator-fips

openshift-ci[bot] commented 7 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-operator-fips

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1249#issuecomment-2063172449): >/override ci/prow/e2e-operator-fips > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

openshift-ci[bot] commented 7 months ago

@tjungblu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-qe-no-capabilities	89aaf6ed6649ddd5356a48ae0d00380158026d5a	link	false	`/test e2e-gcp-qe-no-capabilities`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

hasbro17 commented 7 months ago

/override ci/prow/e2e-aws-ovn-etcd-scaling

Scaling test is passing alright, the failure seems unrelated. event should not see excessive RequiredInstallerResourcesMissing secrets

openshift-ci[bot] commented 7 months ago

@hasbro17: Overrode contexts on behalf of hasbro17: ci/prow/e2e-aws-ovn-etcd-scaling

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1249#issuecomment-2065739609): >/override ci/prow/e2e-aws-ovn-etcd-scaling > >Scaling test is passing alright, the failure seems unrelated. >`event should not see excessive RequiredInstallerResourcesMissing secrets ` Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.16.0-202404190512.p0.g5223e37.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.