search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

NO-JIRA:check the cluster is healthy or not after getting env var, to ensure it is safe to rollout #1262

Closed lance5890 closed 5 months ago

lance5890 commented 6 months ago
  1. similar to the https://github.com/openshift/cluster-etcd-operator/pull/1239, I found the ceo could also rollout when remove one master node
  2. the targetconfigcontroller should check the cluster is safe or not when get env vars, in case the env vas have changed, but the cluster is not healthy yet
openshift-ci[bot] commented 6 months ago

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
lance5890 commented 6 months ago

/cc @tjungblu

tjungblu commented 5 months ago

/ok-to-test

tjungblu commented 5 months ago

/lgtm

thanks @lance5890!

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance5890, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 months ago

@lance5890: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1262): >1. similar to the https://github.com/openshift/cluster-etcd-operator/pull/1239, I found the ceo could also rollout when remove one master node >2. the targetconfigcontroller should check the cluster is safe or not when get env vars, in case the env vas have changed, but the cluster is not healthy yet > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 5 months ago

@lance5890 the branch is currently still "frozen" for the imminent release, so we'll just wait for the label requirement to lift :)

tjungblu commented 5 months ago

ah well, just got an email that the label is being lifted. Thanks a ton @lance5890 - I check back later to see if this got merged

openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD 00a3a5ca4cb300054e557193b5fc8183493ebabc and 2 for PR HEAD a23784067d88f17375b34e51f13685515a7d4c8f in total

lance5890 commented 5 months ago

/test e2e-agnostic-ovn-upgrade

openshift-ci[bot] commented 5 months ago

@lance5890: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-qe-no-capabilities a23784067d88f17375b34e51f13685515a7d4c8f link false /test e2e-gcp-qe-no-capabilities

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 5 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202405221214.p0.g07a4ba1.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.