search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

ETCD-620: Update api vendor libraries to get GA'ed tuning profiles #1264

Closed dusk125 closed 5 months ago

dusk125 commented 5 months ago

go get github.com/openshift/api@e278985

openshift-ci-robot commented 5 months ago

@dusk125: This pull request references ETCD-498 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1264): >`go get -u github.com/openshift/api@e278985bcf1b48d6206884ebb8eee7bf3675afb7` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Elbehery commented 5 months ago

/lgtm /approve

tjungblu commented 5 months ago

/retest

tjungblu commented 5 months ago

/retest

openshift-ci-robot commented 5 months ago

@dusk125: This pull request references ETCD-498 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1264): >`go get github.com/openshift/api@e278985` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 5 months ago

/lgtm

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,dusk125,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD b693e5ef0a3a0ac075d2eedbb0e8fe35d0165938 and 2 for PR HEAD f7447cfe3ce82f9d574732566616768c261c8271 in total

openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD 803828d88829ab2d28ba99292572b3965d0f96db and 1 for PR HEAD f7447cfe3ce82f9d574732566616768c261c8271 in total

openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD 45972c187ec4f96f99db181f99ab62e3efb3ca79 and 0 for PR HEAD f7447cfe3ce82f9d574732566616768c261c8271 in total

dusk125 commented 5 months ago

/retest-required

openshift-ci-robot commented 5 months ago

/hold

Revision f7447cfe3ce82f9d574732566616768c261c8271 was retested 3 times: holding

openshift-ci-robot commented 5 months ago

@dusk125: This pull request references ETCD-620 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1264): >`go get github.com/openshift/api@e278985` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dusk125 commented 5 months ago

/hold cancel

dusk125 commented 5 months ago

/retest-required

openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD 0b37c819d483af11a18e8b223a713e374fbcea25 and 2 for PR HEAD f7447cfe3ce82f9d574732566616768c261c8271 in total

dusk125 commented 5 months ago

/retest-required

dusk125 commented 5 months ago

/test e2e-agnostic-ovn

openshift-ci[bot] commented 5 months ago

@dusk125: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery f7447cfe3ce82f9d574732566616768c261c8271 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-operator-fips f7447cfe3ce82f9d574732566616768c261c8271 link false /test e2e-operator-fips
ci/prow/e2e-gcp-qe-no-capabilities f7447cfe3ce82f9d574732566616768c261c8271 link false /test e2e-gcp-qe-no-capabilities

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dusk125 commented 5 months ago

/test e2e-aws-ovn-etcd-scaling

dusk125 commented 5 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 5 months ago

@dusk125: #1264 failed to apply on top of branch "release-4.16":

Applying: ETCD-498: Update api vendor libraries to get GA'ed tuning profiles
Using index info to reconstruct a base tree...
M   go.mod
M   go.sum
M   vendor/github.com/openshift/api/Makefile
M   vendor/github.com/openshift/api/config/v1/types_infrastructure.go
M   vendor/github.com/openshift/api/config/v1/types_network.go
M   vendor/github.com/openshift/api/config/v1/zz_generated.featuregated-crd-manifests.yaml
M   vendor/github.com/openshift/api/features.md
M   vendor/github.com/openshift/api/imageregistry/v1/types.go
M   vendor/github.com/openshift/api/imageregistry/v1/zz_generated.featuregated-crd-manifests.yaml
M   vendor/github.com/openshift/api/imageregistry/v1/zz_generated.swagger_doc_generated.go
M   vendor/github.com/openshift/api/operator/v1/types_machineconfiguration.go
M   vendor/github.com/openshift/api/operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-Default.crd.yaml
M   vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging vendor/github.com/openshift/api/features.md
CONFLICT (content): Merge conflict in vendor/github.com/openshift/api/features.md
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ETCD-498: Update api vendor libraries to get GA'ed tuning profiles
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1264#issuecomment-2150584113): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 5 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202406052200.p0.g83914c7.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.