search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

ETCD-603: add revision helpers #1267

Closed tjungblu closed 5 months ago

tjungblu commented 5 months ago

Salvage from the previous reverted PR we had in 4.16. Note that some of those helpers are not actively used yet, but it's used in a follow-up PR.

openshift-ci-robot commented 5 months ago

@tjungblu: This pull request references ETCD-603 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1267): >Salvage from the previous reverted PR we had in 4.16. Note that some of those helpers are not actively used yet, but it's used in a follow-up PR. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 5 months ago

/retest

dusk125 commented 5 months ago

/lgtm

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [dusk125,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tjungblu commented 5 months ago

/retest-required

openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD b693e5ef0a3a0ac075d2eedbb0e8fe35d0165938 and 2 for PR HEAD 2e26d7f1725b4a221d1b5d1f2175046fbee420ef in total

tjungblu commented 5 months ago

unrelated failures, also on other PRs

/override ci/prow/e2e-aws-ovn-single-node /override ci/prow/e2e-operator /override ci/prow/e2e-agnostic-ovn /override ci/prow/e2e-aws-ovn-serial

openshift-ci[bot] commented 5 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-agnostic-ovn, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-operator

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1267#issuecomment-2135545842): >unrelated failures, also on other PRs > >/override ci/prow/e2e-aws-ovn-single-node >/override ci/prow/e2e-operator >/override ci/prow/e2e-agnostic-ovn >/override ci/prow/e2e-aws-ovn-serial Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 5 months ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator-fips 2e26d7f1725b4a221d1b5d1f2175046fbee420ef link false /test e2e-operator-fips
ci/prow/e2e-gcp-qe-no-capabilities 2e26d7f1725b4a221d1b5d1f2175046fbee420ef link false /test e2e-gcp-qe-no-capabilities
ci/prow/e2e-aws-etcd-recovery 2e26d7f1725b4a221d1b5d1f2175046fbee420ef link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).