search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

ETCD-606: Batch bundle revision rollout #1268

Closed tjungblu closed 5 months ago

tjungblu commented 5 months ago

This PR creates a new "etcd-all-bundles" configmap, similar to "etcd-all-certs", which allows us to transactionally create static pod rollouts on bundle changes.

This is a pre-requisite to allow us to gate leaf certificate changes right after a bundle changes.

--

The TODOs are expected to not have TRT revert weeks-worth of pull request work, this will not change the existing behavior. A follow-up PR will update the CEO status to reflect the changed revision and documentation.

openshift-ci-robot commented 5 months ago

@tjungblu: This pull request references ETCD-606 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1268): >This PR creates a new "etcd-all-bundles" configmap, similar to "etcd-all-certs", which allows us to transactionally create static pod rollouts on bundle changes. > >This is a pre-requisite to allow us to gate leaf certificate changes right after a bundle changes. > >-- > >The TODOs are expected to not have TRT revert weeks-worth of pull request work, this will not change the existing behavior. A follow-up PR will update the CEO status to reflect the changed revision and documentation. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dusk125 commented 5 months ago

/lgtm

openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD 803828d88829ab2d28ba99292572b3965d0f96db and 2 for PR HEAD 345c71ef1d77df85b9c050d79550f76dc104bcf7 in total

tjungblu commented 5 months ago

/label tide/merge-method-squash

tjungblu commented 5 months ago

/retest

dusk125 commented 5 months ago

/lgtm

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [dusk125,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD 803828d88829ab2d28ba99292572b3965d0f96db and 2 for PR HEAD db85a94c15c9d11801401dff148baf6e10bbb110 in total

tjungblu commented 5 months ago

/retest-required

openshift-ci[bot] commented 5 months ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery db85a94c15c9d11801401dff148baf6e10bbb110 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-gcp-qe-no-capabilities db85a94c15c9d11801401dff148baf6e10bbb110 link false /test e2e-gcp-qe-no-capabilities
ci/prow/e2e-operator-fips db85a94c15c9d11801401dff148baf6e10bbb110 link false /test e2e-operator-fips

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).