search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

NO-JIRA: update library-go #1281

Closed tjungblu closed 4 months ago

tjungblu commented 4 months ago

for https://github.com/openshift/library-go/pull/1743 and https://github.com/openshift/library-go/pull/1724

openshift-ci-robot commented 4 months ago

@tjungblu: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1281): >for https://github.com/openshift/library-go/pull/1743 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
p0lyn0mial commented 4 months ago

/lgtm

tjungblu commented 4 months ago

/hold

I might also wait for https://github.com/openshift/library-go/pull/1724 to merge

tjungblu commented 4 months ago

/hold cancel

@Elbehery PTAL if you find some time

Elbehery commented 4 months ago

/lgtm /approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, p0lyn0mial, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 months ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator-fips eb898a7bd67530578df5b5c8eade525072460702 link false /test e2e-operator-fips
ci/prow/e2e-gcp-qe-no-capabilities eb898a7bd67530578df5b5c8eade525072460702 link false /test e2e-gcp-qe-no-capabilities
ci/prow/e2e-aws-etcd-recovery eb898a7bd67530578df5b5c8eade525072460702 link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202406192110.p0.g258a023.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.