search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

NO-JIRA: fix false positive bootstrap in cert signer controller #1283

Closed tjungblu closed 4 months ago

tjungblu commented 4 months ago

on CEO restart the informer is sometimes not synchronized, which causes premature leaf cert generation as the bootstrap thinks it's not done yet.

openshift-ci-robot commented 4 months ago

@tjungblu: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1283): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

tjungblu commented 4 months ago

/hold cancel

/assign @Elbehery can you PTAL?

Elbehery commented 4 months ago

/lgtm /approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 months ago

/retest-required

Remaining retests: 0 against base HEAD 258a023594ad7cf547b3d41d31072a4dc267b65f and 2 for PR HEAD f56049221fe02d82f5e658c5063aa0323cf2195c in total

tjungblu commented 4 months ago

/override ci/prow/e2e-aws-ovn-serial

unrelated OLM failure

openshift-ci[bot] commented 4 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-serial

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1283#issuecomment-2182131730): >/override ci/prow/e2e-aws-ovn-serial > >unrelated OLM failure Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 4 months ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-qe-no-capabilities f56049221fe02d82f5e658c5063aa0323cf2195c link false /test e2e-gcp-qe-no-capabilities
ci/prow/e2e-aws-etcd-recovery f56049221fe02d82f5e658c5063aa0323cf2195c link false /test e2e-aws-etcd-recovery
ci/prow/e2e-operator-fips f56049221fe02d82f5e658c5063aa0323cf2195c link false /test e2e-operator-fips

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202406210743.p0.g0a00f2a.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.