search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

NO-JIRA: cert rotation same assertions #1285

Closed tjungblu closed 4 months ago

tjungblu commented 4 months ago

we have been using different, but similar assertions for the cert rotation in render and the controller. The render assertions were much stronger, so I've added them into testutils and to the controller tests.

openshift-ci-robot commented 4 months ago

@tjungblu: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1285): >we have been using different, but similar assertions for the cert rotation in render and the controller. The render assertions were much stronger, so I've added them into testutils and to the controller tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

hasbro17 commented 4 months ago

/lgtm /retest-required

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [hasbro17,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 months ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 79227b653f2f526fe992e9f7ccce7f337686ace1 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-operator-fips 79227b653f2f526fe992e9f7ccce7f337686ace1 link false /test e2e-operator-fips
ci/prow/e2e-aws-etcd-recovery 79227b653f2f526fe992e9f7ccce7f337686ace1 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 79227b653f2f526fe992e9f7ccce7f337686ace1 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-certrotation 79227b653f2f526fe992e9f7ccce7f337686ace1 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-gcp-qe-no-capabilities 79227b653f2f526fe992e9f7ccce7f337686ace1 link false /test e2e-gcp-qe-no-capabilities

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tjungblu commented 4 months ago

/hold cancel

tjungblu commented 4 months ago

/retest-required

openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202407020721.p0.gd82a13d.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.