search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

ETCD-660: Add `etcd-backup-server` backup vars #1305

Closed Elbehery closed 2 months ago

Elbehery commented 3 months ago

This PR adds etcd-backup-server backupVar.

This is part of https://issues.redhat.com/browse/ETCD-636

cc @openshift/openshift-team-etcd

openshift-ci-robot commented 3 months ago

@Elbehery: This pull request references ETCD-635 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1305): >This PR adds `etcd-backup-server` backupVar. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Elbehery commented 3 months ago

/label tide/merge-method-squash

Elbehery commented 3 months ago

this commit contains the updated etcdpod.yaml manifest

this is just to pass the test .. it can be skipped if conflicts with other PRs

Elbehery commented 3 months ago

/hold

openshift-ci-robot commented 2 months ago

@Elbehery: This pull request references ETCD-636 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1305): >This PR adds `etcd-backup-server` backupVar. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@Elbehery: This pull request references ETCD-660 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1305): >This PR adds `etcd-backup-server` backupVar. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Elbehery commented 2 months ago

The failing unit tests are expected, the test case needs to assert on the update static pod manifest, but it is not merged yet https://github.com/openshift/cluster-etcd-operator/pull/1304

Elbehery commented 2 months ago

@Elbehery

Elbehery commented 2 months ago

The failure here depends on https://github.com/openshift/cluster-etcd-operator/pull/1304 being merged

Basically the test case TestTargetConfigController/Backup_Var_Test needs COMPUTED_BACKUP_VAR for assertion. This var will be added to the manifest here, once https://github.com/openshift/cluster-etcd-operator/pull/1304 is merged

cc @openshift/openshift-team-etcd

Elbehery commented 2 months ago

/retest-required

Elbehery commented 2 months ago

/retest-required

Elbehery commented 2 months ago

@tjungblu shall we label ?

tjungblu commented 2 months ago

you still haven't responded to me in: https://github.com/openshift/cluster-etcd-operator/pull/1305/files#r1741523335 https://github.com/openshift/cluster-etcd-operator/pull/1305/files#r1741524122 https://github.com/openshift/cluster-etcd-operator/pull/1305/files#r1741524818

please don't resolve conversations that are not resolved yet

Elbehery commented 2 months ago

TestNodeDownRevisionSaving passes locally

/retest-required

Elbehery commented 2 months ago

/retest-required

openshift-ci[bot] commented 2 months ago

@Elbehery: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown f21b98a8afc441a3b9ebb8a14436c9c76c697124 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-certrotation f21b98a8afc441a3b9ebb8a14436c9c76c697124 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown f21b98a8afc441a3b9ebb8a14436c9c76c697124 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-recovery f21b98a8afc441a3b9ebb8a14436c9c76c697124 link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tjungblu commented 2 months ago

well done, thanks for your patience.

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.18.0-202409040842.p0.gc014e6f.assembly.stream.el9. All builds following this will include this PR.