search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

[release-4.17] OCPBUGS-38574: use pooled client for etcd single member health checks #1327

Closed openshift-cherrypick-robot closed 1 month ago

openshift-cherrypick-robot commented 2 months ago

This is an automated cherry-pick of #1324

/assign tjungblu

openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-38573 with correct target version. Will retitle the PR to link to the clone. /retitle [release-4.17] OCPBUGS-38574: use pooled client for etcd single member health checks

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1327): >This is an automated cherry-pick of #1324 > >/assign tjungblu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-38574, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1327): >This is an automated cherry-pick of #1324 > >/assign tjungblu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dusk125 commented 2 months ago

/lgtm /label backport-risk-assessed

tjungblu commented 2 months ago

/hold

we'll wait for the first z release

tjungblu commented 2 months ago

/retest

openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 88d790b4365caf29ebd1f1b054530fd3e0945441 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-recovery 88d790b4365caf29ebd1f1b054530fd3e0945441 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-etcd-certrotation 88d790b4365caf29ebd1f1b054530fd3e0945441 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 88d790b4365caf29ebd1f1b054530fd3e0945441 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tjungblu commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@tjungblu: This pull request references Jira Issue OCPBUGS-38574, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-38573](https://issues.redhat.com//browse/OCPBUGS-38573) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-38573](https://issues.redhat.com//browse/OCPBUGS-38573) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @geliu2016

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1327#issuecomment-2315012836): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, geliu2016, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/release-4.17/OWNERS)~~ [dusk125] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tjungblu commented 1 month ago

/hold cancel

tjungblu commented 1 month ago

/retest-required

tjungblu commented 1 month ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 1 month ago

@tjungblu: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1327#issuecomment-2386177568): >/cherry-pick release-4.16 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 8f04f689ce0dd513660e87ce4c12c7f0bf7747eb and 2 for PR HEAD 88d790b4365caf29ebd1f1b054530fd3e0945441 in total

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-38574: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38574 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1327): >This is an automated cherry-pick of #1324 > >/assign tjungblu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.17.0-202410030035.p0.g975fc01.assembly.stream.el9. All builds following this will include this PR.