search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

NO-JIRA: update library-go to latest #1329

Closed tjungblu closed 2 months ago

openshift-ci-robot commented 2 months ago

@tjungblu: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1329): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 2 months ago

please take a quick look whether those changes are sensible w.r.t to what's done in library go

/assign @vrutkovs

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD fde15811e0a41ec0754397282937942b3f893645 and 2 for PR HEAD 89c955dd9cbfd7ad458a70b9710727454a05c592 in total

dusk125 commented 2 months ago

/lgtm

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD fde15811e0a41ec0754397282937942b3f893645 and 2 for PR HEAD 520de2646d5cbf60552f39ab24029cde512f5b36 in total

tjungblu commented 2 months ago

/hold

needs further fixing in library-go

tjungblu commented 2 months ago

/hold cancel

vrutkovs commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, tjungblu, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [dusk125,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tjungblu commented 2 months ago

/retest-required

openshift-ci[bot] commented 2 months ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-certrotation b86a93c205475aefcb23f6cee1387b83a2b20de5 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown b86a93c205475aefcb23f6cee1387b83a2b20de5 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-recovery b86a93c205475aefcb23f6cee1387b83a2b20de5 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown b86a93c205475aefcb23f6cee1387b83a2b20de5 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.18.0-202409021542.p0.gd2a0273.assembly.stream.el9. All builds following this will include this PR.