search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

ETCD-686: Remove etcd-backup-server StaticPod approach #1358

Closed Elbehery closed 1 month ago

Elbehery commented 1 month ago

This PR removes etcd-backup-server based on StaticPod.

The StaticPod approach has been replaced by https://github.com/openshift/cluster-etcd-operator/pull/1354

Comparing against 4.17 branch link

resolves https://issues.redhat.com/browse/ETCD-686

cc @openshift/openshift-team-etcd

openshift-ci-robot commented 1 month ago

@Elbehery: This pull request references ETCD-686 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1358): >This PR removes `etcd-backup-server` based on StaticPod. > >The `StaticPod` approach has been replaced by https://github.com/openshift/cluster-etcd-operator/pull/1354 > >resolves https://issues.redhat.com/browse/ETCD-686 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@Elbehery: This pull request references ETCD-686 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1358): >This PR removes `etcd-backup-server` based on StaticPod. > >The `StaticPod` approach has been replaced by https://github.com/openshift/cluster-etcd-operator/pull/1354 > >Comparing against 4.17 branch [link](https://github.com/openshift/cluster-etcd-operator/compare/release-4.17...Elbehery:remove_etcd-backup-server_staticPod) > >resolves https://issues.redhat.com/browse/ETCD-686 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 28467760b688785bf62a463b5ba545892cbd9471 and 2 for PR HEAD ebe422896c1cb91a83743731989ac4c02804ba40 in total

openshift-ci[bot] commented 1 month ago

@Elbehery: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-certrotation ebe422896c1cb91a83743731989ac4c02804ba40 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-aws-etcd-recovery ebe422896c1cb91a83743731989ac4c02804ba40 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown ebe422896c1cb91a83743731989ac4c02804ba40 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.18.0-202410151810.p0.gdf38d11.assembly.stream.el9. All builds following this will include this PR.