search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

WIP certsignercontroller: avoid using resourceapply.ApplySecret #1362

Open vrutkovs opened 3 weeks ago

vrutkovs commented 3 weeks ago

This method makes an extra GET, which is costly for such a large secret. Instead it uses a version from cache, runs a single GET and uses server-side apply to update it

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs Once this PR has been reviewed and has the lgtm label, please assign elbehery for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 weeks ago

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/081fe680-96da-11ef-91f4-cde4735e474b-0

openshift-ci[bot] commented 2 weeks ago

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a7c78740-96f5-11ef-8917-56e896fcf5d0-0

openshift-ci[bot] commented 2 weeks ago

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 970cadb3800db793ef5b144a8a76d20e3e1795c0 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 970cadb3800db793ef5b144a8a76d20e3e1795c0 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-certrotation 970cadb3800db793ef5b144a8a76d20e3e1795c0 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-aws-ovn-etcd-scaling 970cadb3800db793ef5b144a8a76d20e3e1795c0 link true /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-agnostic-ovn-upgrade 970cadb3800db793ef5b144a8a76d20e3e1795c0 link true /test e2e-agnostic-ovn-upgrade
ci/prow/e2e-aws-etcd-recovery 970cadb3800db793ef5b144a8a76d20e3e1795c0 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-ovn-serial 970cadb3800db793ef5b144a8a76d20e3e1795c0 link true /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 2 weeks ago

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/20169390-9790-11ef-9369-5b6a6b14fab2-0