openshift / cluster-image-registry-operator

The image registry operator installs+maintains the internal registry on a cluster
Apache License 2.0
58 stars 123 forks source link

WIP: OCPBUGS-41903: pkg/operator/azurepathfixcontroller: do not sync on non-azure storage #1118

Closed flavianmissi closed 1 month ago

flavianmissi commented 2 months ago

or when the operator is removed.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-image-registry-operator/blob/master/OWNERS)~~ [flavianmissi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
flavianmissi commented 2 months ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 2 months ago

@flavianmissi: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-image-registry-operator/pull/1118#issuecomment-2352385817): >/cherry-pick release-4.17 release-4.16 release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

@flavianmissi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images c6d61245d7a78db6881434a4e1c93f50072c8767 link true /test images
ci/prow/e2e-azure-ovn c6d61245d7a78db6881434a4e1c93f50072c8767 link false /test e2e-azure-ovn
ci/prow/e2e-azure-operator c6d61245d7a78db6881434a4e1c93f50072c8767 link false /test e2e-azure-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
flavianmissi commented 2 months ago

/retitle WIP: OCPBUGS-41903: pkg/operator/azurepathfixcontroller: do not sync on non-azure storage

marking the PR as WIP because I'm still trying to understand what's happening on the customer's cluster.

openshift-ci-robot commented 2 months ago

@flavianmissi: This pull request references Jira Issue OCPBUGS-41903, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-image-registry-operator/pull/1118): >or when the operator is removed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-image-registry-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
flavianmissi commented 1 month ago

This does not fix the linked bug. /close

openshift-ci[bot] commented 1 month ago

@flavianmissi: Closed this PR.

In response to [this](https://github.com/openshift/cluster-image-registry-operator/pull/1118#issuecomment-2363050585): >This does not fix the linked bug. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

@flavianmissi: This pull request references Jira Issue OCPBUGS-41903. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-image-registry-operator/pull/1118): >or when the operator is removed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-image-registry-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.