search

openshift / cluster-image-registry-operator

The image registry operator installs+maintains the internal registry on a cluster
Apache License 2.0
58 stars 123 forks source link

OCPBUGS-42196: pkg/storage/azure: use cluster-api tag key to discover vnet #1120

Closed flavianmissi closed 1 month ago

flavianmissi commented 1 month ago

the previous tag key seems to no longer be added to clusters created using the cluster-api since 4.17.

Making it WIP because we're not sure if this is the right way to go, or if the installer should be backwards compatible and continue tagging the vnet using the previous format.

flavianmissi commented 1 month ago

Confirmed with the installer folks that we should use both upstream (cluster-api) and our own tag keys to filter the vnet - removing WIP.

/retitle OCPBUGS-42196: pkg/storage/azure: use cluster-api tag key to discover vnet

openshift-ci-robot commented 1 month ago

@flavianmissi: This pull request references Jira Issue OCPBUGS-42196, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (xiuwang+1@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-image-registry-operator/pull/1120): >the previous tag key seems to no longer be added to clusters created using the cluster-api since 4.17. > >--- > >Making it WIP because we're not sure if this is the right way to go, or if the installer should be backwards compatible and continue tagging the vnet using the previous format. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-image-registry-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
flavianmissi commented 1 month ago

infra issues on aws CI /retest

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-image-registry-operator/blob/master/OWNERS)~~ [flavianmissi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
flavianmissi commented 1 month ago

Putting on hold so QE has a chance to pre-merge test. /hold

flavianmissi commented 1 month ago

failures look infra related /retest

xiuwang commented 1 month ago

/label qe-approved

openshift-ci-robot commented 1 month ago

@flavianmissi: This pull request references Jira Issue OCPBUGS-42196, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (xiuwang+1@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/cluster-image-registry-operator/pull/1120): >the previous tag key seems to no longer be added to clusters created using the cluster-api since 4.17. > >--- > >Making it WIP because we're not sure if this is the right way to go, or if the installer should be backwards compatible and continue tagging the vnet using the previous format. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-image-registry-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
flavianmissi commented 1 month ago

PR is approved by QE - removing hold /hold cancel

flavianmissi commented 1 month ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 1 month ago

@flavianmissi: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-image-registry-operator/pull/1120#issuecomment-2370618598): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 249d1a752890a5ea08babb0e7ba85a147f28c0b8 and 2 for PR HEAD 847b329e10536cae8b0b0a4fb9dcfe6d77f32e04 in total

flavianmissi commented 1 month ago

/retest

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 249d1a752890a5ea08babb0e7ba85a147f28c0b8 and 2 for PR HEAD 847b329e10536cae8b0b0a4fb9dcfe6d77f32e04 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 249d1a752890a5ea08babb0e7ba85a147f28c0b8 and 2 for PR HEAD 847b329e10536cae8b0b0a4fb9dcfe6d77f32e04 in total

openshift-ci[bot] commented 1 month ago

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@flavianmissi: Jira Issue OCPBUGS-42196: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42196 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-image-registry-operator/pull/1120): >the previous tag key seems to no longer be added to clusters created using the cluster-api since 4.17. > >--- > >Making it WIP because we're not sure if this is the right way to go, or if the installer should be backwards compatible and continue tagging the vnet using the previous format. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-image-registry-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 1 month ago

@flavianmissi: new pull request created: #1125

In response to [this](https://github.com/openshift/cluster-image-registry-operator/pull/1120#issuecomment-2370618598): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-image-registry-operator This PR has been included in build ose-cluster-image-registry-operator-container-v4.18.0-202409250208.p0.g8853265.assembly.stream.el9. All builds following this will include this PR.