search

openshift / cluster-image-registry-operator

The image registry operator installs+maintains the internal registry on a cluster
Apache License 2.0
58 stars 123 forks source link

MULTIARCH-5164: Update powervs-utils regions to include us-south and tor #1157

Closed AshwinHIBM closed 1 day ago

AshwinHIBM commented 3 days ago

The latest version of powervs-utils includes some new zones. Update the version to this.

openshift-ci[bot] commented 3 days ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

AshwinHIBM commented 3 days ago

/retitle MULTIARCH-5164: Update powervs-utils regions to include us-south and tor

openshift-ci-robot commented 3 days ago

@AshwinHIBM: This pull request references MULTIARCH-5164 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-image-registry-operator/pull/1157): >The latest version of `powervs-utils` includes some new zones. Update the version to this. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-image-registry-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
AshwinHIBM commented 3 days ago

/assign @mjturek

flavianmissi commented 3 days ago

Hi @AshwinHIBM , it looks like you missed running go mod tidy && go mod vendor - that's why the tests are failing.

AshwinHIBM commented 3 days ago

Hi @AshwinHIBM , it looks like you missed running go mod tidy && go mod vendor - that's why the tests are failing.

Thanks, indeed I had. Let's hope it works now.

AshwinHIBM commented 3 days ago

/test e2e-hypershift

AshwinHIBM commented 2 days ago

/retest-required

flavianmissi commented 2 days ago

/lgtm

openshift-ci[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AshwinHIBM, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-image-registry-operator/blob/master/OWNERS)~~ [flavianmissi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
flavianmissi commented 2 days ago

@AshwinHIBM this PR will also need docs and PX approval. Is there any need for documentation from your team's end? Is there anyone from product experience (PX) we'd want to ping?

@xiuwang can help us with QE approval. Please let us know if you need any details, Xiujuan.

mjturek commented 2 days ago

@flavianmissi nothing needed on documentation or product-experience IMO. This will simply expand the number of valid zones to match what's in the installer.

flavianmissi commented 2 days ago

Makes sense @mjturek! I'll add the labels in that case.

/label docs-approved /label px-approved

xiuwang commented 1 day ago

Hi @juliemathew , could u give a hand to provide the cluster on power-vs platform?

xiuwang commented 1 day ago

/label qe-approved Cluster-bot can't build multi-arch image from PR, I will test after this code merged. Then @pranavgaikwad could provide me the cluster, thank you.

openshift-ci-robot commented 1 day ago

@AshwinHIBM: This pull request references MULTIARCH-5164 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-image-registry-operator/pull/1157): >The latest version of `powervs-utils` includes some new zones. Update the version to this. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-image-registry-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 day ago

@AshwinHIBM: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 day ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-image-registry-operator This PR has been included in build ose-cluster-image-registry-operator-container-v4.18.0-202411151408.p0.g92d64a7.assembly.stream.el9. All builds following this will include this PR.