search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

api_performance_dashboard: show apiserver_request_total instead of apiserver_dropped_requests #1520

Closed p0lyn0mial closed 1 year ago

p0lyn0mial commented 1 year ago

the prevoius apiserver_dropped_requests metric was depreciated in https://github.com/kubernetes/kubernetes/pull/110337

xref: https://github.com/openshift/cluster-kube-apiserver-operator/pull/1518

p0lyn0mial commented 1 year ago

/assign @dgrisonnet

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [dgrisonnet,p0lyn0mial] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 2bf134c638ea1be66df40bef9e8f1b63b9bef4f0 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-operator-single-node 2bf134c638ea1be66df40bef9e8f1b63b9bef4f0 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 2bf134c638ea1be66df40bef9e8f1b63b9bef4f0 link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).