search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

OCPBUGS-17436: Enable DynamicResourceAllocation API in kube-apiserver #1538

Closed bertinatto closed 1 year ago

bertinatto commented 1 year ago

/assign @benluddy CC @ingvagabund @soltysh

openshift-ci-robot commented 1 year ago

@bertinatto: This pull request references Jira Issue OCPBUGS-17436, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1538): >/assign @benluddy >CC @ingvagabund @soltysh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
benluddy commented 1 year ago

/lgtm /assign @tkashem

bertinatto commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@bertinatto: This pull request references Jira Issue OCPBUGS-17436, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1538#issuecomment-1686695554): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bertinatto commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@bertinatto: This pull request references Jira Issue OCPBUGS-17436, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1538#issuecomment-1686696990): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [benluddy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bertinatto commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@bertinatto: This pull request references Jira Issue OCPBUGS-17436, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1538#issuecomment-1686699136): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bertinatto commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@bertinatto: This pull request references Jira Issue OCPBUGS-17436, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @wangke19

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1538#issuecomment-1686701607): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
benluddy commented 1 year ago

/hold

To allow time for a smoke test since there is no tech preview presubmit.

bertinatto commented 1 year ago

TechPreview cluster installed successfully:

~ ❯ oc get clusterversion
NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         3m33s   Cluster version is 4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest

~ ❯ oc get co
NAME                                       VERSION                                                   AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
authentication                             4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      4m8s
baremetal                                  4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      24m
cloud-controller-manager                   4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      28m
cloud-credential                           4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      28m
cluster-api                                4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      24m
cluster-autoscaler                         4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      24m
config-operator                            4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      25m
console                                    4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      6m49s
control-plane-machine-set                  4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      21m
csi-snapshot-controller                    4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      24m
dns                                        4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      24m
etcd                                       4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      23m
image-registry                             4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      11m
ingress                                    4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      12m
insights                                   4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      18m
kube-apiserver                             4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      7m4s
kube-controller-manager                    4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      23m
kube-scheduler                             4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      22m
kube-storage-version-migrator              4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      25m
machine-api                                4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      10m
machine-approver                           4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      24m
machine-config                             4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      3m25s
marketplace                                4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      23m
monitoring                                 4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      3m59s
network                                    4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      26m
node-tuning                                4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      24m
olm                                        4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      10m
openshift-apiserver                        4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      7m9s
openshift-controller-manager               4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      24m
openshift-samples                          4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      17m
operator-lifecycle-manager                 4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      23m
operator-lifecycle-manager-catalog         4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      23m
operator-lifecycle-manager-packageserver   4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      18m
platform-operators-aggregated              4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      7m9s
service-ca                                 4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      25m
storage                                    4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest   True        False         False      11m

~ ❯ oc get featuregates cluster -o yaml
apiVersion: config.openshift.io/v1
kind: FeatureGate
metadata:
  creationTimestamp: "2023-08-21T17:21:53Z"
  generation: 1
  name: cluster
  resourceVersion: "1358"
  uid: c9df204a-0ef8-4499-aaab-c88209ede53d
spec:
  featureSet: TechPreviewNoUpgrade
status:
  featureGates:
  - disabled:
    - name: EventedPLEG
    - name: MachineAPIOperatorDisableMachineHealthCheckController
    enabled:
    - name: AdminNetworkPolicy
    - name: AdmissionWebhookMatchConditions
    - name: AlibabaPlatform
    - name: AutomatedEtcdBackup
    - name: AzureWorkloadIdentity
    - name: BuildCSIVolumes
    - name: CSIDriverSharedResource
    - name: CloudDualStackNodeIPs
    - name: DynamicResourceAllocation
    - name: ExternalCloudProvider
    - name: ExternalCloudProviderAzure
    - name: ExternalCloudProviderExternal
    - name: ExternalCloudProviderGCP
    - name: GCPLabelsTags
    - name: GatewayAPI
    - name: InsightsConfigAPI
    - name: MachineAPIProviderOpenStack
    - name: MaxUnavailableStatefulSet
    - name: NodeSwap
    - name: OpenShiftPodSecurityAdmission
    - name: PrivateHostedZoneAWS
    - name: RetroactiveDefaultStorageClass
    - name: RouteExternalCertificate
    - name: SigstoreImageVerification
    - name: VSphereStaticIPs
    - name: ValidatingAdmissionPolicy
    version: 4.14.0-0.ci.test-2023-08-21-170954-ci-ln-thn79sk-latest

/hold cancel

openshift-ci[bot] commented 1 year ago

@bertinatto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node 3742d3ce6ac5b0ea6ba19ec2f53c8f8b1dae242e link false /test e2e-aws-operator-disruptive-single-node
ci/prow/k8s-e2e-gcp-serial 3742d3ce6ac5b0ea6ba19ec2f53c8f8b1dae242e link false /test k8s-e2e-gcp-serial
ci/prow/e2e-aws-ovn-single-node 3742d3ce6ac5b0ea6ba19ec2f53c8f8b1dae242e link false /test e2e-aws-ovn-single-node
ci/prow/e2e-metal-single-node-live-iso 3742d3ce6ac5b0ea6ba19ec2f53c8f8b1dae242e link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-gcp-operator-single-node 3742d3ce6ac5b0ea6ba19ec2f53c8f8b1dae242e link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 year ago

@bertinatto: Jira Issue OCPBUGS-17436: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17436 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1538): >/assign @benluddy >CC @ingvagabund @soltysh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.