search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

[release-4.14] OCPBUGS-19353: manifests: don't include recording rules when Console capability is not enabled #1551

Closed openshift-cherrypick-robot closed 1 year ago

openshift-cherrypick-robot commented 1 year ago

This is an automated cherry-pick of #1542

/assign vrutkovs

openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-18247 has been cloned as Jira Issue OCPBUGS-19353. Will retitle bug to link to clone. /retitle [release-4.14] OCPBUGS-19353: manifests: don't include recording rules when Console capability is not enabled

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1551): >This is an automated cherry-pick of #1542 > >/assign vrutkovs Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19353, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-18247](https://issues.redhat.com//browse/OCPBUGS-18247) is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-18247](https://issues.redhat.com//browse/OCPBUGS-18247) targets the "4.15.0" version, which is one of the valid target versions: 4.15.0 * bug has dependents

Requesting review from QA contact: /cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1551): >This is an automated cherry-pick of #1542 > >/assign vrutkovs Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vrutkovs commented 1 year ago

/retest-required

openshift-ci[bot] commented 1 year ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 3a2275ca1e99d641e59e48b19730609a8fb4f2d9 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 3a2275ca1e99d641e59e48b19730609a8fb4f2d9 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node 3a2275ca1e99d641e59e48b19730609a8fb4f2d9 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dgrisonnet commented 1 year ago

/lgtm /approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/release-4.14/OWNERS)~~ [dgrisonnet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-19353: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19353 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1551): >This is an automated cherry-pick of #1542 > >/assign vrutkovs Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-merge-robot commented 1 year ago

Fix included in accepted release 4.14.0-0.nightly-2023-09-22-154021