search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

OCPBUGS-20331: manifests: rename API performance dashboard #1565

Closed vrutkovs closed 1 year ago

vrutkovs commented 1 year ago

In previous PR this manifests was labelled as "available only when Console capability enabled". This causes CVO to force enable Console capability when upgrading from baseline 4.13 cluster - as this manifest is present.

In order to avoid this, the manifest needs to be renamed, so that CVO would treat it as a new one (since its applicability has changed)

vrutkovs commented 1 year ago

/cc @evakhoni

I wonder if CVO will correctly remove the previous manifests. Please make sure no new dashboards appear on Observe - Dashboard

openshift-ci-robot commented 1 year ago

@vrutkovs: This pull request references Jira Issue OCPBUGS-20331, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1565): >In previous PR this manifests was labelled as "available only when Console capability enabled". This causes CVO to force enable Console capability when upgrading from baseline 4.13 cluster - as this manifest is present. > >In order to avoid this, the manifest needs to be renamed, so that CVO would treat it as a new one (since its applicability has changed) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vrutkovs commented 1 year ago

/cherrypick release-4.14

openshift-cherrypick-robot commented 1 year ago

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1565#issuecomment-1755360385): >/cherrypick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vrutkovs commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@vrutkovs: This pull request references Jira Issue OCPBUGS-20331, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @evakhoni

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1565#issuecomment-1755361428): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@vrutkovs: This pull request references Jira Issue OCPBUGS-20331, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @evakhoni

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1565): >In [previous PR](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1542) this manifests was labelled as "available only when Console capability enabled". This causes CVO to force enable Console capability when upgrading from baseline 4.13 cluster - as this manifest is present. > >In order to avoid this, the manifest needs to be renamed, so that CVO would treat it as a new one (since its applicability has changed) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
evakhoni commented 1 year ago

I wonder if CVO will correctly remove the previous manifests. Please make sure no new dashboards appear on Observe - Dashboard

I guess Observe - Dashboard would be inaccessible, since no Console installed

openshift-ci[bot] commented 1 year ago

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node 7457da4fc0c78246947574883b5d1214ad0f9d3c link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-metal-single-node-live-iso 7457da4fc0c78246947574883b5d1214ad0f9d3c link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-gcp-operator-single-node 7457da4fc0c78246947574883b5d1214ad0f9d3c link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [dgrisonnet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 year ago

/retest-required

Remaining retests: 0 against base HEAD d01fc2ab557994e27d980483411b2429e53b13f7 and 2 for PR HEAD 7457da4fc0c78246947574883b5d1214ad0f9d3c in total

openshift-ci-robot commented 1 year ago

@vrutkovs: Jira Issue OCPBUGS-20331: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-20331 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1565): >In [previous PR](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1542) this manifests was labelled as "available only when Console capability enabled". This causes CVO to force enable Console capability when upgrading from baseline 4.13 cluster - as this manifest is present. > >In order to avoid this, the manifest needs to be renamed, so that CVO would treat it as a new one (since its applicability has changed) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 year ago

@vrutkovs: new pull request created: #1570

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1565#issuecomment-1755360385): >/cherrypick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-merge-robot commented 1 year ago

Fix included in accepted release 4.15.0-0.nightly-2023-10-31-054858