search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

NO-ISSUE: Revert "add SNO control plane high cpu usage alert" #1674

Closed p0lyn0mial closed 6 months ago

p0lyn0mial commented 6 months ago

This reverts commit d92b46166259ef43918e9f7cd6bc62f09a806d1f.

Based on https://github.com/openshift/cluster-kube-apiserver-operator/pull/1673/files#r1595019004 we have decided to revert.

p0lyn0mial commented 6 months ago

/assign @qJkee @tkashem

p0lyn0mial commented 6 months ago

@qJkee is going to prepare a new PR that will create a new controller or will use the StaticResourceController if possible. Thanks!

openshift-ci[bot] commented 6 months ago

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-single-node-live-iso fdc7ec699d08b149ca39b2289f5c0797d46bb4e3 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-aws-ovn-single-node fdc7ec699d08b149ca39b2289f5c0797d46bb4e3 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-operator-single-node fdc7ec699d08b149ca39b2289f5c0797d46bb4e3 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node fdc7ec699d08b149ca39b2289f5c0797d46bb4e3 link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tkashem commented 6 months ago

/lgtm /approve

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [p0lyn0mial,tkashem] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 6 months ago

@p0lyn0mial: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1674): >This reverts commit d92b46166259ef43918e9f7cd6bc62f09a806d1f. > >Based on https://github.com/openshift/cluster-kube-apiserver-operator/pull/1673/files#r1595019004 we have decided to revert. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.16.0-202405100946.p0.gb352992.assembly.stream.el9 for distgit ose-cluster-kube-apiserver-operator. All builds following this will include this PR.