openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

OCPBUGS-34062: [4.13] add a controller that reconciles SCCs' volumes #1677

Closed stlaz closed 6 months ago

stlaz commented 6 months ago

backport of https://github.com/openshift/cluster-kube-apiserver-operator/pull/1675

/assign @openshift/openshift-team-auth-maintainers

openshift-ci[bot] commented 6 months ago

@stlaz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node af0df168a142e8ef70c33e18eef94407b17f0608 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node af0df168a142e8ef70c33e18eef94407b17f0608 link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
stlaz commented 6 months ago

/label backport-risk-assessed

xingxingxia commented 6 months ago

/label cherry-pick-approved

sdodson commented 6 months ago

/jira cherry-pick OCPBUGS-33930

openshift-ci-robot commented 6 months ago

@sdodson: Jira Issue OCPBUGS-33930 has been cloned as Jira Issue OCPBUGS-34062. Will retitle bug to link to clone. /retitle OCPBUGS-34062: [4.13] add a controller that reconciles SCCs' volumes

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1677#issuecomment-2123075229): >/jira cherry-pick OCPBUGS-33930 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@stlaz: This pull request references Jira Issue OCPBUGS-34062, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1677): >backport of https://github.com/openshift/cluster-kube-apiserver-operator/pull/1675 > >/assign @openshift/openshift-team-auth-maintainers Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sdodson commented 6 months ago

No dev-cut-off for 4.13.z this week so got a week for this to merge.

xingxingxia commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@xingxingxia: This pull request references Jira Issue OCPBUGS-34062, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1677#issuecomment-2123786985): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
stlaz commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@stlaz: This pull request references Jira Issue OCPBUGS-34062, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.13.z) matches configured target version for branch (4.13.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-33930](https://issues.redhat.com//browse/OCPBUGS-33930) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-33930](https://issues.redhat.com//browse/OCPBUGS-33930) targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z * bug has dependents

Requesting review from QA contact: /cc @xingxingxia

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1677#issuecomment-2124093154): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
p0lyn0mial commented 6 months ago

/lgtm

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/release-4.13/OWNERS)~~ [p0lyn0mial] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 6 months ago

@stlaz: Jira Issue OCPBUGS-34062: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34062 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1677): >backport of https://github.com/openshift/cluster-kube-apiserver-operator/pull/1675 > >/assign @openshift/openshift-team-auth-maintainers Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.13.0-202405220836.p0.g1448124.assembly.stream.el8 for distgit ose-cluster-kube-apiserver-operator. All builds following this will include this PR.

openshift-merge-robot commented 6 months ago

Fix included in accepted release 4.13.0-0.nightly-2024-05-22-100809