search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

Remove ValidatingAdmissionPolicy DefaultGroupVersionsByFeatureGate #1687

Closed dinhxuanvu closed 2 months ago

dinhxuanvu commented 6 months ago

ValidatingAdmissionPolicy is now GA with v1 so it is enabled by default. This DefaultGroupVersionsByFeatureGate for this API is no longer needed.

dinhxuanvu commented 6 months ago

Hold until after 1.30 rebase /hold

openshift-ci-robot commented 6 months ago

@dinhxuanvu: This pull request references API-1783 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1687): >ValidatingAdmissionPolicy is now GA with v1 so it is enabled by default. This DefaultGroupVersionsByFeatureGate for this API is no longer needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dinhxuanvu commented 6 months ago

/retest-required

dinhxuanvu commented 6 months ago

Hold until origin is rebased. /hold

dinhxuanvu commented 5 months ago

/retest

dinhxuanvu commented 5 months ago

/retest-required

dinhxuanvu commented 5 months ago

/hold cancel

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [dinhxuanvu,soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD 94ca049d55ee0f070f7fcad9b12a1f1c45ce47cb and 2 for PR HEAD 6f65a934d784e09b78e5c64686b8dde5c80e7f72 in total

dinhxuanvu commented 5 months ago

/retest-required

openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD 58d79ab9d65972bbd706e0787d149e7c0aef1774 and 1 for PR HEAD 6f65a934d784e09b78e5c64686b8dde5c80e7f72 in total

openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD c3adc9ebf7aeb1d34428d3a15b8d49cb0e990d70 and 0 for PR HEAD 6f65a934d784e09b78e5c64686b8dde5c80e7f72 in total

openshift-ci-robot commented 5 months ago

/hold

Revision 6f65a934d784e09b78e5c64686b8dde5c80e7f72 was retested 3 times: holding

openshift-ci[bot] commented 5 months ago

@dinhxuanvu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-single-node-live-iso 6f65a934d784e09b78e5c64686b8dde5c80e7f72 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-aws-ovn-single-node 6f65a934d784e09b78e5c64686b8dde5c80e7f72 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-operator-single-node 6f65a934d784e09b78e5c64686b8dde5c80e7f72 link false /test e2e-gcp-operator-single-node
ci/prow/k8s-e2e-gcp-serial 6f65a934d784e09b78e5c64686b8dde5c80e7f72 link false /test k8s-e2e-gcp-serial
ci/prow/e2e-aws-operator-disruptive-single-node 6f65a934d784e09b78e5c64686b8dde5c80e7f72 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-aws-ovn-upgrade 6f65a934d784e09b78e5c64686b8dde5c80e7f72 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-serial 6f65a934d784e09b78e5c64686b8dde5c80e7f72 link true /test e2e-aws-ovn-serial
ci/prow/k8s-e2e-gcp 6f65a934d784e09b78e5c64686b8dde5c80e7f72 link true /test k8s-e2e-gcp
ci/prow/e2e-gcp-operator 6f65a934d784e09b78e5c64686b8dde5c80e7f72 link true /test e2e-gcp-operator
ci/prow/e2e-aws-ovn 6f65a934d784e09b78e5c64686b8dde5c80e7f72 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 5 months ago

@dinhxuanvu: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1687): >ValidatingAdmissionPolicy is now GA with v1 so it is enabled by default. This DefaultGroupVersionsByFeatureGate for this API is no longer needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-merge-robot commented 2 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dinhxuanvu commented 2 months ago

No longer needed /close

openshift-ci[bot] commented 2 months ago

@dinhxuanvu: Closed this PR.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1687#issuecomment-2358662329): >No longer needed >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.