search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

OCPBUGS-34544: Disable PersistentVolumeLabel admission plugin #1693

Closed jsafrane closed 5 months ago

jsafrane commented 6 months ago

PersistentVolumeLabel admission plugin needs a valid cloud config. kube-apiserver does not get it in OCP 4.17, and thus it rejects valid in-tree GCE PersistentVolumes.

The admission plugin was deprecated upstream a long time ago, it was removed from Kubernetes 1.31 (OCP 4.18) and it cannot work without a cloud provider in kube-apiserver anyway.

cc @openshift/storage

openshift-ci-robot commented 6 months ago

@jsafrane: This pull request references Jira Issue OCPBUGS-34544, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1693): >PersistentVolumeLabel admission plugin needs a valid cloud config. kube-apiserver does not get it in OCP 4.17, and thus it rejects valid in-tree GCE PersistentVolumes. > >The admission plugin was deprecated upstream a long time ago, it was removed from Kubernetes 1.31 (OCP 4.18) and it cannot work without a cloud provider in kube-apiserver anyway. > >cc @openshift/storage Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
nrb commented 6 months ago

/retest

jsafrane commented 5 months ago

k8s-e2e-gcp-serial with failing SELinuxMount metrics is not related to this PR - it most probably needs kubelet 1.30, which is not yet present in RHCOS. I am not able to judge the other errors

elmiko commented 5 months ago

thanks for posting this @jsafrane

/lgtm

tkashem commented 5 months ago

/approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, jsafrane, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [tkashem] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD 09258494e5c99595825898f90cedb46d7b3964b4 and 2 for PR HEAD 60392c12f52742ea6f9df605250b53287c2c24e8 in total

jsafrane commented 5 months ago

/retest-required

openshift-ci[bot] commented 5 months ago

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node 60392c12f52742ea6f9df605250b53287c2c24e8 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 60392c12f52742ea6f9df605250b53287c2c24e8 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/k8s-e2e-gcp-serial 60392c12f52742ea6f9df605250b53287c2c24e8 link false /test k8s-e2e-gcp-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jsafrane commented 5 months ago

/retest-required

openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD c700fe87e9de7ef8f5bff659fd3c548863c3657e and 1 for PR HEAD 60392c12f52742ea6f9df605250b53287c2c24e8 in total

openshift-ci-robot commented 5 months ago

@jsafrane: Jira Issue OCPBUGS-34544: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-34544 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1693): >PersistentVolumeLabel admission plugin needs a valid cloud config. kube-apiserver does not get it in OCP 4.17, and thus it rejects valid in-tree GCE PersistentVolumes. > >The admission plugin was deprecated upstream a long time ago, it was removed from Kubernetes 1.31 (OCP 4.18) and it cannot work without a cloud provider in kube-apiserver anyway. > >cc @openshift/storage Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 5 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.17.0-202406060211.p0.g94ca049.assembly.stream.el9 for distgit ose-cluster-kube-apiserver-operator. All builds following this will include this PR.

rphillips commented 5 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 5 months ago

@rphillips: new pull request created: #1702

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1693#issuecomment-2174496766): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.