search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

NO-JIRA: nodekubeconfigcontroller: set ownership component for node kubeconfigs #1704

Closed vrutkovs closed 4 months ago

vrutkovs commented 5 months ago

Kubeconfigs are parsed as TLS artifact registry sources, so secrets containing kubeconfigs should have necessary annotations

openshift-ci-robot commented 5 months ago

@vrutkovs: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1704): >Kubeconfigs are parsed as TLS artifact registry sources, so secrets containing kubeconfigs should have necessary annotations Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vrutkovs commented 4 months ago

/cc @sanchezl @p0lyn0mial

p0lyn0mial commented 4 months ago

/lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [p0lyn0mial,vrutkovs] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 months ago

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node e3a54c158a1dadc93f0107a7b310b7d1cf888842 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node e3a54c158a1dadc93f0107a7b310b7d1cf888842 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.17.0-202407111842.p0.g0ecdda5.assembly.stream.el9 for distgit ose-cluster-kube-apiserver-operator. All builds following this will include this PR.