search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

[WIP] certrotationcontroller: make signers and caBunldes thread safe #1710

Closed p0lyn0mial closed 4 months ago

p0lyn0mial commented 4 months ago

a proof for https://github.com/openshift/library-go/pull/1753

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [p0lyn0mial] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 months ago

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node 20f6d16d980afa364a1e945778012b0b03b388dc link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-ovn-single-node 20f6d16d980afa364a1e945778012b0b03b388dc link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 20f6d16d980afa364a1e945778012b0b03b388dc link false /test e2e-aws-operator-disruptive-single-node
ci/prow/verify-deps 20f6d16d980afa364a1e945778012b0b03b388dc link true /test verify-deps

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
p0lyn0mial commented 4 months ago

/close

openshift-ci[bot] commented 4 months ago

@p0lyn0mial: Closed this PR.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1710#issuecomment-2210719018): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.