search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

NO-JIRA: Rename Dockerfile #1711

Open ashwindasr opened 4 months ago

ashwindasr commented 4 months ago

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: https://github.com/openshift/release/pull/54001 (probably needs to merge first)

Please follow up with other changes in this/other repos if necessary. Please reach out to ART once this PR is ready to merge.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashwindasr Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 months ago

@ashwindasr: This pull request references Jira Issue OCPBUGS-36529, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1711): >Refactor name to `Dockerfile.ocp` as a better, version independent, alternative since contents are actually rhel9. > >CI: https://github.com/openshift/release/pull/54001 (probably needs to merge first) > >Please follow up with other changes in this/other repos if necessary. ART has setup the necessary [fallbacks](https://github.com/openshift-eng/ocp-build-data/pull/5039), but only for 4.17, if backporting this PR, please give us a heads up. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

@ashwindasr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 414411a0e06dfcd6cbd570611140efa109146b60 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn 414411a0e06dfcd6cbd570611140efa109146b60 link true /test e2e-aws-ovn
ci/prow/e2e-gcp-operator 414411a0e06dfcd6cbd570611140efa109146b60 link true /test e2e-gcp-operator
ci/prow/k8s-e2e-gcp 414411a0e06dfcd6cbd570611140efa109146b60 link true /test k8s-e2e-gcp
ci/prow/e2e-metal-single-node-live-iso 414411a0e06dfcd6cbd570611140efa109146b60 link false /test e2e-metal-single-node-live-iso
ci/prow/k8s-e2e-gcp-serial 414411a0e06dfcd6cbd570611140efa109146b60 link false /test k8s-e2e-gcp-serial
ci/prow/e2e-aws-operator-disruptive-single-node 414411a0e06dfcd6cbd570611140efa109146b60 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-aws-ovn-serial 414411a0e06dfcd6cbd570611140efa109146b60 link true /test e2e-aws-ovn-serial
ci/prow/images 414411a0e06dfcd6cbd570611140efa109146b60 link true /test images
ci/prow/e2e-aws-ovn-single-node 414411a0e06dfcd6cbd570611140efa109146b60 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-operator-single-node 414411a0e06dfcd6cbd570611140efa109146b60 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 4 months ago

@ashwindasr: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1711): >Refactor name to `Dockerfile.ocp` as a better, version independent, alternative since contents are actually rhel9. > >CI: https://github.com/openshift/release/pull/54001 (probably needs to merge first) > >Please follow up with other changes in this/other repos if necessary. ART has setup the necessary [fallbacks](https://github.com/openshift-eng/ocp-build-data/pull/5039), but only for 4.17, if backporting this PR, please give us a heads up. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ashwindasr commented 4 months ago

/hold

Needs to merge with an ocp-build-data PR

openshift-bot commented 1 month ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-merge-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 week ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale