search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

ETCD-636: add etcd backup cert #1713

Closed Elbehery closed 4 months ago

Elbehery commented 4 months ago

This PR adds a certificate to be used by etcd backup server

resolves https://issues.redhat.com/browse/ETCD-636

cc @soltysh @p0lyn0mial @openshift/openshift-team-etcd

openshift-ci-robot commented 4 months ago

@Elbehery: This pull request references ETCD-636 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1713): >This PR adds a certificate to be used by `etcd backup server` > >resolves https://issues.redhat.com/browse/ETCD-636 > >cc @soltysh @p0lyn0mial @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery Once this PR has been reviewed and has the lgtm label, please assign sanchezl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Elbehery commented 4 months ago

/retest-required

openshift-ci[bot] commented 4 months ago

@Elbehery: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 021c3c01ee00c2f01b49d7b8a5547f95a43524cd link false /test e2e-aws-ovn-single-node
ci/prow/e2e-metal-single-node-live-iso 021c3c01ee00c2f01b49d7b8a5547f95a43524cd link false /test e2e-metal-single-node-live-iso
ci/prow/k8s-e2e-gcp-serial 021c3c01ee00c2f01b49d7b8a5547f95a43524cd link false /test k8s-e2e-gcp-serial
ci/prow/e2e-gcp-operator-single-node 021c3c01ee00c2f01b49d7b8a5547f95a43524cd link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 021c3c01ee00c2f01b49d7b8a5547f95a43524cd link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
vrutkovs commented 4 months ago

This looks correct, but it should use controllers from https://github.com/openshift/library-go/pull/1722, otherwise it would race on signer updates

Elbehery commented 4 months ago

/close

openshift-ci[bot] commented 4 months ago

@Elbehery: Closed this PR.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1713#issuecomment-2238516288): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.