search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

NO-JIRA: exclude etcd check from livez #1724

Closed p0lyn0mial closed 2 months ago

p0lyn0mial commented 3 months ago

the motivation for removal is the belief that a broken connection to the etcd cluster will not be fixed by simply deleting the KAS pod.

alternative to https://github.com/openshift/kubernetes/pull/2061

openshift-ci-robot commented 3 months ago

@p0lyn0mial: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1724): >the motivation for removal is the belief that a broken connection to the etcd cluster will not be fixed by simply deleting the KAS pod. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
p0lyn0mial commented 3 months ago

/hold

for manual verification

p0lyn0mial commented 3 months ago

/assign @deads2k

p0lyn0mial commented 3 months ago

verified manually

/hold cancel

deads2k commented 3 months ago

/lgtm /cherry-pick release-4.17 /hold holding so we can retest with https://github.com/openshift/origin/pull/29032 to see if resolves our lease acquisition problem.

if the fix works, we'll want it in 4.17

openshift-cherrypick-robot commented 3 months ago

@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1724#issuecomment-2313210966): >/lgtm >/cherry-pick release-4.17 >/hold holding so we can retest with https://github.com/openshift/origin/pull/29032 to see if resolves our lease acquisition problem. > >if the fix works, we'll want it in 4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [deads2k,p0lyn0mial] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
deads2k commented 2 months ago

/test all

now that https://github.com/openshift/origin/pull/29032 is in

openshift-ci[bot] commented 2 months ago

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node f4ae2e3100090d0328a481d9332aa309ce41f3b7 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node f4ae2e3100090d0328a481d9332aa309ce41f3b7 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
deads2k commented 2 months ago

Well this didn't help this particular problem

p0lyn0mial commented 2 months ago

/close

in favour of https://github.com/openshift/cluster-kube-apiserver-operator/pull/1732

openshift-ci[bot] commented 2 months ago

@p0lyn0mial: Closed this PR.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1724#issuecomment-2345533634): >/close > >in favour of https://github.com/openshift/cluster-kube-apiserver-operator/pull/1732 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.