search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

OCPBUGS-41257: introduce --operand-kubernetes-version flag and resolve API group versions accordingly #1731

Closed atiratree closed 2 months ago

openshift-ci-robot commented 2 months ago

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1731): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@atiratree: This pull request references Jira Issue OCPBUGS-41257, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1731): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
atiratree commented 2 months ago

/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview

openshift-ci[bot] commented 2 months ago

@atiratree: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/488d0090-6bce-11ef-8966-eb46bf1fb1bf-0

atiratree commented 2 months ago

/retest

atiratree commented 2 months ago

techpreview job passed https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-cluster-kube-apiserver-operator-1731-ci-4.18-e2e-aws-ovn-techpreview/1831807523313684480

and we can observe the correct API group version

2024-09-05T22:17:42.380607615Z I0905 22:17:42.380581      15 flags.go:64] FLAG: --runtime-config="admissionregistration.k8s.io/v1beta1=true,resource.k8s.io/v1alpha2=true"
benluddy commented 2 months ago

/hold

I asked for some minor changes around the same time as the LGTM so I'd like to at least allow time to consider the range suggestion.

benluddy commented 2 months ago

/hold cancel /lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, benluddy, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [benluddy,dinhxuanvu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
atiratree commented 2 months ago

/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview

openshift-ci[bot] commented 2 months ago

@atiratree: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5cab7d80-6c79-11ef-801a-7d45ab795866-0

atiratree commented 2 months ago

/hold let's wait for the techpreview test results first

bertinatto commented 2 months ago

/hold let's wait for the techpreview test results first

TechPreview test is green: https://pr-payload-tests.ci.openshift.org/runs/ci/5cab7d80-6c79-11ef-801a-7d45ab795866-0

/hold cancel

openshift-ci[bot] commented 2 months ago

@atiratree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node fa7f7d5b6400115f267b1b5c4e72eea7a27f59f7 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node fa7f7d5b6400115f267b1b5c4e72eea7a27f59f7 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@atiratree: Jira Issue OCPBUGS-41257: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-41257 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1731): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-kube-apiserver-operator This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.18.0-202409070043.p0.g5d12697.assembly.stream.el9. All builds following this will include this PR.