search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

WRKLDS-1449: cleanup flag validation after they have been added to the installer #1736

Closed atiratree closed 2 months ago

openshift-ci-robot commented 2 months ago

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1736): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
atiratree commented 2 months ago

/retest

openshift-ci-robot commented 2 months ago

@atiratree: This pull request references Jira Issue OCPBUGS-41257, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1736): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1736): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
benluddy commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, benluddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [benluddy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
atiratree commented 2 months ago

Thanks!

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 56d4c7e74d34c3e0c349428c327943f0e3a5fed5 and 2 for PR HEAD cbe3f11c064c8e61047457dd158dcc22c94da105 in total

openshift-ci[bot] commented 2 months ago

@atiratree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node cbe3f11c064c8e61047457dd158dcc22c94da105 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node cbe3f11c064c8e61047457dd158dcc22c94da105 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-kube-apiserver-operator This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.18.0-202409202309.p0.g9fb047a.assembly.stream.el9. All builds following this will include this PR.