search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

WIP add support for minimumKubeletVersion #1754

Open haircommander opened 1 month ago

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haircommander Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
haircommander commented 1 month ago

/retest

p0lyn0mial commented 4 days ago

How are we planning to test this observer? Are we going to have an integration test? At the very least, we could check if the configuration contains the current node version, right? I think we could have a more end-to-end test in origin.

haircommander commented 4 days ago

I was planning on doing an e2e test in origin. I'm not seeing integration tests in this repository, do you have a pointer @p0lyn0mial ?

openshift-ci[bot] commented 3 days ago

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-encryption-rotation-aesgcm 04811824035c8735198aadfba568cc317f96617d link false /test e2e-gcp-operator-encryption-rotation-aesgcm
ci/prow/e2e-gcp-operator-encryption-rotation-single-node 04811824035c8735198aadfba568cc317f96617d link false /test e2e-gcp-operator-encryption-rotation-single-node
ci/prow/e2e-gcp-operator-encryption-single-node 04811824035c8735198aadfba568cc317f96617d link false /test e2e-gcp-operator-encryption-single-node
ci/prow/e2e-gcp-operator-encryption-perf-single-node 04811824035c8735198aadfba568cc317f96617d link false /test e2e-gcp-operator-encryption-perf-single-node
ci/prow/e2e-gcp-operator-encryption-aescbc 04811824035c8735198aadfba568cc317f96617d link false /test e2e-gcp-operator-encryption-aescbc
ci/prow/e2e-gcp-operator-single-node e019d985dc315e7049798963e207a77c247f89f8 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node e019d985dc315e7049798963e207a77c247f89f8 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-aws-ovn-upgrade e019d985dc315e7049798963e207a77c247f89f8 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node e019d985dc315e7049798963e207a77c247f89f8 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).