search

openshift / cluster-kube-controller-manager-operator

The kube-controller-manager operator installs and maintains the kube-controller-manager on a cluster
Apache License 2.0
43 stars 126 forks source link

OCPCLOUD-2514: Remove reliance on Cloud Provider feature gates for determining if CCM should be deployed. #794

Closed JoelSpeed closed 8 months ago

JoelSpeed commented 8 months ago

Library go no longer requires feature gates for observing cloud provider state. This PR updates library go to remove the reliance, and ensures that feature gate access is no longer being passed into the cloud provider observers.

A follow up to this is needed to make sure that the --cloud-provider, --external-cloud-volume-plugin and --cloud-config flags are cleared now they are no longer required, will add that as a separate PR later.

openshift-ci-robot commented 8 months ago

@JoelSpeed: This pull request references OCPCLOUD-2514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-kube-controller-manager-operator/pull/794): >Library go no longer requires feature gates for observing cloud provider state. This PR updates library go to remove the reliance, and ensures that feature gate access is no longer being passed into the cloud provider observers. > >A follow up to this is needed to make sure that the `--cloud-provider`, `--external-cloud-volume-plugin` and `--cloud-config` flags are cleared now they are no longer required, will add that as a separate PR later. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-controller-manager-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
JoelSpeed commented 8 months ago

/retest

elmiko commented 8 months ago

i don't think the latest failures are related, but i'm not that familiar with them.

/approve /lgtm

/test e2e-aws-ovn

openshift-ci[bot] commented 8 months ago

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ingvagabund commented 8 months ago

/approve

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, ingvagabund, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-controller-manager-operator/blob/master/OWNERS)~~ [ingvagabund] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 8 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-controller-manager-operator-container-v4.16.0-202403050309.p0.g5a8a98f.assembly.stream.el9 for distgit ose-cluster-kube-controller-manager-operator. All builds following this will include this PR.