search

openshift / cluster-kube-controller-manager-operator

The kube-controller-manager operator installs and maintains the kube-controller-manager on a cluster
Apache License 2.0
43 stars 126 forks source link

[WIP] Remove cloud-provider, cloud-config, and cloud-volume-plugin flags #807

Closed dinhxuanvu closed 5 months ago

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dinhxuanvu Once this PR has been reviewed and has the lgtm label, please assign atiratree for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-kube-controller-manager-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dinhxuanvu commented 5 months ago

/payload-job periodic-ci-openshift-release-master-ci-4.16-e2e-azure-sdn-upgrade

openshift-ci[bot] commented 5 months ago

@dinhxuanvu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ba738470-13f6-11ef-895f-5f7992ceaeda-0

soltysh commented 5 months ago

https://github.com/openshift/library-go/pull/1736 fixes the problem, already tested manually. I'm going to pick it up in https://github.com/openshift/cluster-kube-controller-manager-operator/pull/806