search

openshift / cluster-kube-controller-manager-operator

The kube-controller-manager operator installs and maintains the kube-controller-manager on a cluster
Apache License 2.0
43 stars 126 forks source link

OCPBUGS-34859: manifests: set owning-component for csr-signer-signer #812

Closed vrutkovs closed 4 months ago

vrutkovs commented 5 months ago

Ensure that the secret has necessary annotations applied on creation time, so that the controller didn't have to wait for changes in the secret to apply ownership annotations. This fixes a regression after https://github.com/openshift/cluster-kube-controller-manager-operator/pull/804

vrutkovs commented 5 months ago

/test e2e-aws-ovn

openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

vrutkovs commented 5 months ago

/test e2e-aws-ovn

vrutkovs commented 5 months ago

/test e2e-aws-ovn

openshift-ci-robot commented 5 months ago

@vrutkovs: This pull request references Jira Issue OCPBUGS-34859, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-controller-manager-operator/pull/812): >Ensure that the secret has necessary annotations applied on creation time, so that the controller didn't have to wait for changes in the secret to apply ownership annotations. This fixes a regression after https://github.com/openshift/cluster-kube-controller-manager-operator/pull/804 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-controller-manager-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vrutkovs commented 5 months ago

/retest

zhouying7780 commented 5 months ago

/label qe-approved

openshift-ci-robot commented 5 months ago

@vrutkovs: This pull request references Jira Issue OCPBUGS-34859, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/cluster-kube-controller-manager-operator/pull/812): >Ensure that the secret has necessary annotations applied on creation time, so that the controller didn't have to wait for changes in the secret to apply ownership annotations. This fixes a regression after https://github.com/openshift/cluster-kube-controller-manager-operator/pull/804 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-controller-manager-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ingvagabund commented 4 months ago

/approve /lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-controller-manager-operator/blob/master/OWNERS)~~ [ingvagabund] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 months ago

/retest-required

Remaining retests: 0 against base HEAD a1afb4c381b817e9465105f9860560607e338fb9 and 2 for PR HEAD 36b73b0c51533e635062ca1fec4d4b047d197c25 in total

openshift-ci[bot] commented 4 months ago

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 4 months ago

@vrutkovs: Jira Issue OCPBUGS-34859: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34859 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-kube-controller-manager-operator/pull/812): >Ensure that the secret has necessary annotations applied on creation time, so that the controller didn't have to wait for changes in the secret to apply ownership annotations. This fixes a regression after https://github.com/openshift/cluster-kube-controller-manager-operator/pull/804 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-controller-manager-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-controller-manager-operator-container-v4.17.0-202406172015.p0.g4d78b1c.assembly.stream.el9 for distgit ose-cluster-kube-controller-manager-operator. All builds following this will include this PR.