Closed simonpasquier closed 8 months ago
@simonpasquier: This pull request references Jira Issue OCPBUGS-18326, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
/jira refresh
@simonpasquier: This pull request references Jira Issue OCPBUGS-18326, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @juzhao
@simonpasquier: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/versions | d84f0f382883329a7f71053576ee75e7ab476e7c | link | false | /test versions |
ci/prow/e2e-aws-ovn-single-node | d84f0f382883329a7f71053576ee75e7ab476e7c | link | false | /test e2e-aws-ovn-single-node |
Full PR test history. Your PR dashboard.
Nice, thank you! Love the commit message :heart:
/lgtm
/skip
Thanks /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jan--f, machine424, simonpasquier
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@simonpasquier: Jira Issue OCPBUGS-18326: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-18326 has been moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202402071412.p0.gdbcfed9.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.
Fix included in accepted release 4.16.0-0.nightly-2024-02-08-025333
This commit adds the "capability.openshift.io/name: Console" annotation to the dashboard configmaps.
It also renames the existing configmaps from "grafana-xxx" to "xxx" because otherwise CVO would enable the Console capability on all clusters, even those where the capability was initially disabled [1]. The CVO team has a feature request [2] to improve the situation but for now, we have no other option than creating the configmaps with a different name and deleting the old configmaps (anyway the "grafana-" prefix is misleading since OCP doesn't ship any Grafana instance by default).
[1] https://github.com/openshift/enhancements/blob/master/enhancements/installer/component-selection.md#how-to-implement-a-new-capability [2] https://issues.redhat.com/browse/OTA-1039