search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

OCPNODE-2100: jsonnet: update crio port to TLS port 9637 #2257

Closed rphillips closed 7 months ago

rphillips commented 8 months ago

This PR switches monitoring over to use the secure 9637 metrics port for crio (backed by kube-rbac-proxy). It also changes the authentication to use the client certificate auth, since static pods cannot mount secrets.

openshift-ci-robot commented 8 months ago

@rphillips: This pull request references OCPNODE-2022 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2257): >This reverts commit ee975658d0b1ad7d774b947857f895fa5a5822c9. > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rphillips commented 8 months ago

/payload help

rphillips commented 8 months ago

/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

rphillips commented 8 months ago

/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10

openshift-ci[bot] commented 8 months ago

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5c020710-c5c5-11ee-922b-dca000ede010-0

rphillips commented 8 months ago

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

openshift-ci[bot] commented 8 months ago

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/820f5280-c6d5-11ee-97cb-3e05c7124d92-0

rphillips commented 8 months ago

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 https://github.com/openshift/machine-config-operator/pull/4175

rphillips commented 8 months ago

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 https://github.com/openshift/machine-config-operator/pull/4175

rphillips commented 8 months ago

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

openshift-ci[bot] commented 8 months ago

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/896bb770-c93d-11ee-8788-320a5f153a65-0

rphillips commented 8 months ago

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

openshift-ci[bot] commented 8 months ago

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0d734920-c9ca-11ee-824a-026157b75804-0

rphillips commented 8 months ago

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

openshift-ci[bot] commented 8 months ago

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/56f50e00-ca7c-11ee-974b-7cd8f62e7155-0

rphillips commented 8 months ago

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

openshift-ci[bot] commented 8 months ago

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/71d442f0-d03e-11ee-95a3-a9525782e9b1-0

rphillips commented 8 months ago

Another set of test runs:

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

openshift-ci[bot] commented 8 months ago

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ee6ad150-d046-11ee-8944-22e78ea98d14-0

sairameshv commented 8 months ago

Trying out the payload test on a new PR

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 https://github.com/openshift/machine-config-operator/pull/4209

rphillips commented 8 months ago

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4209

openshift-ci[bot] commented 8 months ago

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/947aaa00-d0bc-11ee-8a88-f4397baa2cbc-0

rphillips commented 8 months ago

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

openshift-ci[bot] commented 8 months ago

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2fe383e0-d0bd-11ee-810a-f5690c54df5d-0

rphillips commented 7 months ago

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10 openshift/machine-config-operator#4175

openshift-ci[bot] commented 7 months ago

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e5c27b20-d4d3-11ee-9ec6-9109614adb72-0

openshift-ci-robot commented 7 months ago

@rphillips: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2257): >This reverts commit ee975658d0b1ad7d774b947857f895fa5a5822c9. > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 7 months ago

@rphillips: This pull request references OCPNODE-2100 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2257): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rphillips commented 7 months ago

/hold for https://github.com/openshift/machine-config-operator/pull/4175

openshift-ci[bot] commented 7 months ago

@rphillips: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 1c0aa30491bca80122d6b65df56a6f73f993f313 link false /test versions
ci/prow/e2e-aws-ovn-single-node 1c0aa30491bca80122d6b65df56a6f73f993f313 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rphillips commented 7 months ago

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10

openshift-ci[bot] commented 7 months ago

@rphillips: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

rphillips commented 7 months ago

/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10

openshift-ci[bot] commented 7 months ago

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b0a66fe0-e005-11ee-9e0d-e60f3f7a9b45-0

rphillips commented 7 months ago

/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10

openshift-ci[bot] commented 7 months ago

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0001cb10-e07f-11ee-9aca-a93d433e5341-0

rphillips commented 7 months ago

This should be testing with 4.15.3 now (with crio static pods)

/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 10

openshift-ci[bot] commented 7 months ago

@rphillips: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0e213a50-e09d-11ee-9437-435f617d856c-0

rphillips commented 7 months ago

Test passed from 4.15 to master... I need to get 2 more PRs into 4.14 so that EUS upgrades work.

rphillips commented 7 months ago

4.14 merged.

This PR is now ready.

/hold cancel

openshift-ci-robot commented 7 months ago

@rphillips: This pull request references OCPNODE-2100 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2257): >This PR switches monitoring over to use the secure 9637 metrics port for crio (backed by kube-rbac-proxy). It also changes the authentication to use the client certificate auth, since static pods cannot mount secrets. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rphillips commented 7 months ago

/retest-required

danielmellado commented 7 months ago

/lgtm thanks!

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, harche, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [danielmellado] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202403230015.p0.ge761b9e.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.