search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

MON-3706: chore: poll immediately in the e2e tests #2258

Closed simonpasquier closed 8 months ago

simonpasquier commented 8 months ago

It should speed up the test run if we check the condition immediately instead of waiting for 5 seconds.

machine424 commented 8 months ago

/lgtm Thought about doing the same for the client's one https://github.com/openshift/cluster-monitoring-operator/blob/dbcfed9c91a37adbc1e2eb5af5e09172d701cdff/pkg/client/client.go#L2037 but I was worried about getting more failure logs + making unnecessary requests. (especially for delete ones that are known to take time.) unlike tests, It' not a problem if the sync takes an extra 5 seconds (especially that the tasks run in //).

openshift-ci-robot commented 8 months ago

@simonpasquier: This pull request references MON-3706 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2258): >It should speed up the test run if we check the condition immediately instead of waiting for 5 seconds. > > > >* [ ] I added CHANGELOG entry for this change. >* [x] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
simonpasquier commented 8 months ago

/skip

simonpasquier commented 8 months ago

@machine424 100% agreed: for CMO tasks, waiting an extra 5s is often not a big deal.

openshift-ci-robot commented 8 months ago

/retest-required

Remaining retests: 0 against base HEAD dbcfed9c91a37adbc1e2eb5af5e09172d701cdff and 2 for PR HEAD de9cb0dea2bbdf4aebe13b4401dd0ba07f5ee52a in total

simonpasquier commented 8 months ago

/retest-required

openshift-ci-robot commented 8 months ago

/retest-required

Remaining retests: 0 against base HEAD b7e3f50875f2bb1fed912b23fb80a101d3a786c0 and 1 for PR HEAD de9cb0dea2bbdf4aebe13b4401dd0ba07f5ee52a in total

simonpasquier commented 8 months ago

/retest images

openshift-ci[bot] commented 8 months ago

@simonpasquier: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2258#issuecomment-1936055188): >/retest images Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
simonpasquier commented 8 months ago

/test images

simonpasquier commented 8 months ago

The latest run took 5561s (https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-monitoring-operator/2188/pull-ci-openshift-cluster-monitoring-operator-master-e2e-agnostic-operator/1757316599150284800/artifacts/e2e-agnostic-operator/test/build-log.txt). I've looked at another run (https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-monitoring-operator/2188/pull-ci-openshift-cluster-monitoring-operator-master-e2e-agnostic-operator/1757316599150284800/artifacts/e2e-agnostic-operator/test/build-log.txt) and it took 6855s.

simonpasquier commented 8 months ago

/test e2e-agnostic-operator

openshift-ci[bot] commented 8 months ago

@simonpasquier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 5038186e1c1bf9c86054444310484cc351357f36 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [machine424,simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
machine424 commented 8 months ago

/hold unhold whenever you want.

simonpasquier commented 8 months ago

/hold cancel

openshift-bot commented 8 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202402141610.p0.g6449c59.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.