openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

[WIP] [ART-8431] Apply hypershift cluster-profile for ibm-cloud-managed #2259

Closed ashwindasr closed 8 months ago

ashwindasr commented 8 months ago

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashwindasr Once this PR has been reviewed and has the lgtm label, please assign machine424 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jupierce commented 8 months ago

/retest

openshift-ci[bot] commented 8 months ago

@ashwindasr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 298296bc3d966a7b0f6a8bd170d62579cb356135 link false /test versions
ci/prow/generate 298296bc3d966a7b0f6a8bd170d62579cb356135 link true /test generate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
simonpasquier commented 8 months ago

some files are generated from jsonnet, you'll probably need to update: https://github.com/openshift/cluster-monitoring-operator/blob/master/jsonnet/utils/add-annotations.libsonnet if it's too complicated, we (monitoring team) can take over the PR cc @jan--f

ashwindasr commented 8 months ago

@simonpasquier thanks. will add the change there as well.

Also migrated the PR to our bot account. Will push updates there.

/close

in favor of https://github.com/openshift/cluster-monitoring-operator/pull/2263

openshift-ci[bot] commented 8 months ago

@ashwindasr: Closed this PR.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2259#issuecomment-1946309505): >@simonpasquier thanks. will add the change there as well. > >Also migrated the PR to our bot account. Will push updates there. > >/close > >in favor of https://github.com/openshift/cluster-monitoring-operator/pull/2263 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.