Closed ashwindasr closed 8 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ashwindasr Once this PR has been reviewed and has the lgtm label, please assign machine424 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/retest
@ashwindasr: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/versions | 298296bc3d966a7b0f6a8bd170d62579cb356135 | link | false | /test versions |
ci/prow/generate | 298296bc3d966a7b0f6a8bd170d62579cb356135 | link | true | /test generate |
Full PR test history. Your PR dashboard.
some files are generated from jsonnet, you'll probably need to update: https://github.com/openshift/cluster-monitoring-operator/blob/master/jsonnet/utils/add-annotations.libsonnet if it's too complicated, we (monitoring team) can take over the PR cc @jan--f
@simonpasquier thanks. will add the change there as well.
Also migrated the PR to our bot account. Will push updates there.
/close
in favor of https://github.com/openshift/cluster-monitoring-operator/pull/2263
@ashwindasr: Closed this PR.
Since HyperShift / Hosted Control Plane have adopted
include.release.openshift.io/ibm-cloud-managed
, to tailor the resources of clusters running in the ROKS IBM environment, theinclude.release.openshift.io/hypershift
addition will allow Hypershift to express different profile choices than ROKS