Closed openshift-art-build-bot closed 8 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: openshift-art-build-bot Once this PR has been reviewed and has the lgtm label, please assign machine424 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@simonpasquier Looking into the code, I see that the config flow is not that straightforward, so yes, I would appreciate if the team can take over. cc @jan--f
@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29531, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
/jira refresh
@ashwindasr: This pull request references Jira Issue OCPBUGS-29531, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @juzhao
@ashwindasr @simonpasquier just put up this PR https://github.com/openshift/cluster-monitoring-operator/pull/2264 with the changes including our jsonnet config
Thanks @danielmellado! Please feel free to close this in favor that one!
@openshift-art-build-bot: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-aws-ovn-techpreview | 007434d432d4a3a97d36f88e8cb25517133be4c9 | link | true | /test e2e-aws-ovn-techpreview |
ci/prow/generate | 007434d432d4a3a97d36f88e8cb25517133be4c9 | link | true | /test generate |
ci/prow/versions | 007434d432d4a3a97d36f88e8cb25517133be4c9 | link | false | /test versions |
Full PR test history. Your PR dashboard.
/close
In favor of https://github.com/openshift/cluster-monitoring-operator/pull/2264
@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29531. The bug has been updated to no longer refer to the pull request using the external bug tracker.
@ashwindasr: Closed this PR.
Since HyperShift / Hosted Control Plane have adopted
include.release.openshift.io/ibm-cloud-managed
, to tailor the resources of clusters running in the ROKS IBM environment, theinclude.release.openshift.io/hypershift
addition will allow Hypershift to express different profile choices than ROKS