openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

OCPBUGS-29531: Apply hypershift cluster-profile for ibm-cloud-managed #2263

Closed openshift-art-build-bot closed 8 months ago

openshift-art-build-bot commented 8 months ago

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-art-build-bot Once this PR has been reviewed and has the lgtm label, please assign machine424 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ashwindasr commented 8 months ago

@simonpasquier Looking into the code, I see that the config flow is not that straightforward, so yes, I would appreciate if the team can take over. cc @jan--f

openshift-ci-robot commented 8 months ago

@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29531, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2263): >Since HyperShift / Hosted Control Plane have adopted `include.release.openshift.io/ibm-cloud-managed`, to tailor the resources of clusters running in the ROKS IBM environment, the `include.release.openshift.io/hypershift` addition will allow Hypershift to express different profile choices than ROKS Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ashwindasr commented 8 months ago

/jira refresh

openshift-ci-robot commented 8 months ago

@ashwindasr: This pull request references Jira Issue OCPBUGS-29531, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2263#issuecomment-1946387021): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
danielmellado commented 8 months ago

@ashwindasr @simonpasquier just put up this PR https://github.com/openshift/cluster-monitoring-operator/pull/2264 with the changes including our jsonnet config

ashwindasr commented 8 months ago

Thanks @danielmellado! Please feel free to close this in favor that one!

openshift-ci[bot] commented 8 months ago

@openshift-art-build-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview 007434d432d4a3a97d36f88e8cb25517133be4c9 link true /test e2e-aws-ovn-techpreview
ci/prow/generate 007434d432d4a3a97d36f88e8cb25517133be4c9 link true /test generate
ci/prow/versions 007434d432d4a3a97d36f88e8cb25517133be4c9 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-art-build-bot commented 8 months ago

/close

In favor of https://github.com/openshift/cluster-monitoring-operator/pull/2264

openshift-ci-robot commented 8 months ago

@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29531. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2263): >Since HyperShift / Hosted Control Plane have adopted `include.release.openshift.io/ibm-cloud-managed`, to tailor the resources of clusters running in the ROKS IBM environment, the `include.release.openshift.io/hypershift` addition will allow Hypershift to express different profile choices than ROKS Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 8 months ago

@ashwindasr: Closed this PR.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2263#issuecomment-1952630813): >/close > >In favor of https://github.com/openshift/cluster-monitoring-operator/pull/2264 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.