search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

OCPBUGS-29531: Add include.release.openshift.io/hypershift label #2264

Closed danielmellado closed 6 months ago

danielmellado commented 8 months ago
openshift-ci-robot commented 8 months ago

@danielmellado: This pull request references Jira Issue OCPBUGS-29531, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2264): >* [ ] I added CHANGELOG entry for this change. >* [X] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
danielmellado commented 8 months ago

/assign @simonpasquier @ashwindasr

juzhao commented 8 months ago

/test versions

juzhao commented 8 months ago

/label qe-approved

openshift-ci-robot commented 8 months ago

@danielmellado: This pull request references Jira Issue OCPBUGS-29531, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2264): >* [ ] I added CHANGELOG entry for this change. >* [X] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ashwindasr commented 8 months ago

/retest

danielmellado commented 8 months ago

@bburt-rh mind taking a look at this for the docs-approved label? thanks!

bburt-rh commented 8 months ago

/label docs-approved

ashwindasr commented 8 months ago

/hold

@danielmellado Looks like the annotation is defined in other places in the code base as well. Can you check this diff and pull this in as well if possible?

danielmellado commented 8 months ago

Hi @ashwindasr I've identified a few more places where this was used. Regarding the diff I just see the same files I had, not sure if you wanted to show something else! I can't just pull it in as the manifests are generated from the jsonnet files and they would be overridden. Let me know!

danielmellado commented 8 months ago

/test e2e-aws-ovn-techpreview

ashwindasr commented 8 months ago

Thanks @danielmellado !

As long as include.release.openshift.io/hypershift': 'true' follows all instances of 'include.release.openshift.io/ibm-cloud-managed': 'true' we should be good!

danielmellado commented 7 months ago

/retest-required

machine424 commented 7 months ago

I don't know the effect of the annotation, but /lgtm

machine424 commented 7 months ago

Note that not all files from manifests/ were annotated https://github.com/openshift/cluster-monitoring-operator/tree/master/manifests /hold please unhold if it's ok.

danielmellado commented 7 months ago

Hm, true, i.e. https://github.com/openshift/cluster-monitoring-operator/blob/master/manifests/0000_50_cluster-monitoring-operator_04-config.yaml#L1060 @simonpasquier would it be ok just to update those manually?

danielmellado commented 7 months ago

/unhold

ashwindasr commented 7 months ago

/retest

danielmellado commented 7 months ago

/retest

danielmellado commented 7 months ago

@ashwindasr the version gate is expected to fail given the current openshift release status. So let's just merge this as soon as the other gates pass again (they were passing before your retest xD) Thanks!

simonpasquier commented 7 months ago

/lgtm

openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD 1ffa522529e019e3c559fed6b2a23f1a47ed6a5d and 2 for PR HEAD 41c4a82a769f5836694f6c6d6990569e3576d491 in total

juzhao commented 7 months ago

/retest-required

danielmellado commented 7 months ago

CI Issues seem totally unrelated ({Operator degraded (MissingDependency): machine-api not ready Operator degraded (MissingDependency): machine-api not ready} ) so let's check if we're lucky this time

ashwindasr commented 7 months ago

/retest

danielmellado commented 7 months ago

/retest-required

danielmellado commented 7 months ago

@simonpasquier I'm a bit lost here, this was previously passing and tbh I feel that the issues are unrelated to CMO :\ Do you have any ideas about what could be failing here? Thanks!

danielmellado commented 7 months ago

/retest-required

danielmellado commented 7 months ago

/retest-required

danielmellado commented 7 months ago

there was an issue with CI, let's double check now

simonpasquier commented 7 months ago

/retest-required

openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD b2535467537c2be814912c0301676ef5cbbcbc25 and 1 for PR HEAD 41c4a82a769f5836694f6c6d6990569e3576d491 in total

openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD 5342dee811a66e598aeb9a772c8000d82078a8c0 and 0 for PR HEAD 41c4a82a769f5836694f6c6d6990569e3576d491 in total

openshift-ci-robot commented 7 months ago

/hold

Revision 41c4a82a769f5836694f6c6d6990569e3576d491 was retested 3 times: holding

danielmellado commented 7 months ago

/retest-required

danielmellado commented 7 months ago

/retest-required

danielmellado commented 7 months ago

this passed... not sure what's going on with the CI, it doesn't even get to deploy the cluster.

danielmellado commented 7 months ago

Adding @jparrill and @csrwng, mind taking a look at this CI runs? not sure about the hypershift annotation and I'm aware about the MachineConfigPool recent CI outage but besides that IPI install doesn't even get to finish. Thanks!

danielmellado commented 7 months ago

/retest-required

danielmellado commented 7 months ago

/retest-required

danielmellado commented 7 months ago

/retest-required

openshift-ci-robot commented 7 months ago

@danielmellado: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2264): >* [ ] I added CHANGELOG entry for this change. >* [X] No user facing changes, so no entry in CHANGELOG was needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 7 months ago

@danielmellado: This pull request references Jira Issue OCPBUGS-29531, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2264): >* [ ] I added CHANGELOG entry for this change. >* [X] No user facing changes, so no entry in CHANGELOG was needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 7 months ago

@danielmellado: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2264): >* [ ] I added CHANGELOG entry for this change. >* [X] No user facing changes, so no entry in CHANGELOG was needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 7 months ago

@danielmellado: This pull request references Jira Issue OCPBUGS-29531, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2264): >* [ ] I added CHANGELOG entry for this change. >* [X] No user facing changes, so no entry in CHANGELOG was needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
danielmellado commented 7 months ago

/retest-required

danielmellado commented 7 months ago

/retest-required

danielmellado commented 7 months ago

/retest-required

danielmellado commented 7 months ago

/jira refresh

openshift-ci-robot commented 7 months ago

@danielmellado: This pull request references Jira Issue OCPBUGS-29531, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2264#issuecomment-2008959526): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.