Closed danielmellado closed 6 months ago
@danielmellado: This pull request references Jira Issue OCPBUGS-29531, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @juzhao
The bug has been updated to refer to the pull request using the external bug tracker.
/assign @simonpasquier @ashwindasr
/test versions
/label qe-approved
@danielmellado: This pull request references Jira Issue OCPBUGS-29531, which is valid.
Requesting review from QA contact: /cc @juzhao
/retest
@bburt-rh mind taking a look at this for the docs-approved label? thanks!
/label docs-approved
/hold
@danielmellado Looks like the annotation is defined in other places in the code base as well. Can you check this diff and pull this in as well if possible?
Hi @ashwindasr I've identified a few more places where this was used. Regarding the diff I just see the same files I had, not sure if you wanted to show something else! I can't just pull it in as the manifests are generated from the jsonnet files and they would be overridden. Let me know!
/test e2e-aws-ovn-techpreview
Thanks @danielmellado !
As long as include.release.openshift.io/hypershift': 'true'
follows all instances of 'include.release.openshift.io/ibm-cloud-managed': 'true'
we should be good!
/retest-required
I don't know the effect of the annotation, but /lgtm
Note that not all files from manifests/
were annotated https://github.com/openshift/cluster-monitoring-operator/tree/master/manifests
/hold
please unhold if it's ok.
Hm, true, i.e. https://github.com/openshift/cluster-monitoring-operator/blob/master/manifests/0000_50_cluster-monitoring-operator_04-config.yaml#L1060 @simonpasquier would it be ok just to update those manually?
/unhold
/retest
/retest
@ashwindasr the version gate is expected to fail given the current openshift release status. So let's just merge this as soon as the other gates pass again (they were passing before your retest xD) Thanks!
/lgtm
/retest-required
Remaining retests: 0 against base HEAD 1ffa522529e019e3c559fed6b2a23f1a47ed6a5d and 2 for PR HEAD 41c4a82a769f5836694f6c6d6990569e3576d491 in total
/retest-required
CI Issues seem totally unrelated ({Operator degraded (MissingDependency): machine-api not ready Operator degraded (MissingDependency): machine-api not ready} ) so let's check if we're lucky this time
/retest
/retest-required
@simonpasquier I'm a bit lost here, this was previously passing and tbh I feel that the issues are unrelated to CMO :\ Do you have any ideas about what could be failing here? Thanks!
/retest-required
/retest-required
there was an issue with CI, let's double check now
/retest-required
/retest-required
Remaining retests: 0 against base HEAD b2535467537c2be814912c0301676ef5cbbcbc25 and 1 for PR HEAD 41c4a82a769f5836694f6c6d6990569e3576d491 in total
/retest-required
Remaining retests: 0 against base HEAD 5342dee811a66e598aeb9a772c8000d82078a8c0 and 0 for PR HEAD 41c4a82a769f5836694f6c6d6990569e3576d491 in total
/hold
Revision 41c4a82a769f5836694f6c6d6990569e3576d491 was retested 3 times: holding
/retest-required
/retest-required
this passed... not sure what's going on with the CI, it doesn't even get to deploy the cluster.
Adding @jparrill and @csrwng, mind taking a look at this CI runs? not sure about the hypershift annotation and I'm aware about the MachineConfigPool recent CI outage but besides that IPI install doesn't even get to finish. Thanks!
/retest-required
/retest-required
/retest-required
@danielmellado: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh
.
@danielmellado: This pull request references Jira Issue OCPBUGS-29531, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
@danielmellado: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh
.
@danielmellado: This pull request references Jira Issue OCPBUGS-29531, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
/retest-required
/retest-required
/retest-required
/jira refresh
@danielmellado: This pull request references Jira Issue OCPBUGS-29531, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @juzhao