search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

OCPBUGS-28246: fix Thanos ruler alert generator url #2267

Closed jan--f closed 7 months ago

jan--f commented 8 months ago
openshift-ci-robot commented 8 months ago

@jan--f: This pull request references Jira Issue OCPBUGS-28246, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2267): > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jan--f commented 8 months ago

/retest

juzhao commented 7 months ago

/test versions

juzhao commented 7 months ago

/label qe-approved

openshift-ci-robot commented 7 months ago

@jan--f: This pull request references Jira Issue OCPBUGS-28246, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2267): > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
machine424 commented 7 months ago

/lgtm

machine424 commented 7 months ago

/lgtm

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [jan--f,machine424] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD 5c9a5baf87496bb55f1a341985ff681d245d54f0 and 2 for PR HEAD cb8889665ab1442bddd37ade45bd1d33b24f2613 in total

openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD 1ffa522529e019e3c559fed6b2a23f1a47ed6a5d and 1 for PR HEAD cb8889665ab1442bddd37ade45bd1d33b24f2613 in total

juzhao commented 7 months ago

/test e2e-agnostic-operator

juzhao commented 7 months ago

/retest

openshift-ci[bot] commented 7 months ago

@jan--f: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions cb8889665ab1442bddd37ade45bd1d33b24f2613 link false /test versions
ci/prow/e2e-aws-ovn-single-node cb8889665ab1442bddd37ade45bd1d33b24f2613 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD b2535467537c2be814912c0301676ef5cbbcbc25 and 0 for PR HEAD cb8889665ab1442bddd37ade45bd1d33b24f2613 in total

openshift-ci-robot commented 7 months ago

@jan--f: Jira Issue OCPBUGS-28246: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28246 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2267): > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202403052341.p0.g5342dee.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.

openshift-merge-robot commented 7 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-03-06-073110