search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

OCPBUGS-30257: Making sure proxy settings are correctly forwarded in the generated remote write configs #2269

Closed Nikokolas3270 closed 6 months ago

Nikokolas3270 commented 8 months ago

Fix some golang mistake in which the remoteWrite config objects were copied instead of being passed by reference. This may impact the customers as the remote write calls may now be proxied:

c.c. @simonpasquier

openshift-ci-robot commented 8 months ago

@Nikokolas3270: This pull request references OSD-21081 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2269): >Fix some golang mistake in which the `remoteWrite` config objects were copied instead of being passed by reference. >This may impact the customers as the remote write calls may now be proxied... and this may not work, see: >https://github.com/prometheus-operator/prometheus-operator/issues/6301 > >c.c. @simonpasquier > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 8 months ago

@Nikokolas3270: This pull request references OSD-21081 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2269): >Fix some golang mistake in which the `remoteWrite` config objects were copied instead of being passed by reference. >**This may impact the customers as the remote write calls may now be proxied... and this may not work, see:** >https://github.com/prometheus-operator/prometheus-operator/issues/6301 > >c.c. @simonpasquier > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 8 months ago

@Nikokolas3270: This pull request references OSD-21081 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2269): >Fix some golang mistake in which the `remoteWrite` config objects were copied instead of being passed by reference. >**This may impact the customers as the remote write calls may now be proxied:** >- We may want to fix this issue first: https://github.com/prometheus-operator/prometheus-operator/issues/6301 >- Also it would be nice to have the Prometheus Operator and CMO forward the `noProxy` option on top of the `proxyUrl`; indeed Prometheus is supporting that option: https://github.com/prometheus/prometheus/blob/aba007148057c1947122b18b2ad606883cc27220/docs/configuration/configuration.md#oauth2 > >c.c. @simonpasquier > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 8 months ago

@Nikokolas3270: This pull request references OSD-21081 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2269): >Fix some golang mistake in which the `remoteWrite` config objects were copied instead of being passed by reference. >**This may impact the customers as the remote write calls may now be proxied:** >- We may want to fix this issue first: https://github.com/prometheus-operator/prometheus-operator/issues/6301 >- Also it would be nice to have the Prometheus Operator and CMO forward the `noProxy` option on top of the `proxyUrl`; indeed Prometheus is supporting that option: https://github.com/prometheus/prometheus/blob/main/docs/configuration/configuration.md#oauth2 > >c.c. @simonpasquier > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jan--f commented 8 months ago

/lgtm /retest

openshift-ci-robot commented 8 months ago

/retest-required

Remaining retests: 0 against base HEAD 5c9a5baf87496bb55f1a341985ff681d245d54f0 and 2 for PR HEAD 30e29e3d4bea4b6e33f792c317e2844942deec8a in total

jan--f commented 8 months ago

/retest

jan--f commented 7 months ago

/retest

jan--f commented 7 months ago

/retest-required

openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD 1ffa522529e019e3c559fed6b2a23f1a47ed6a5d and 1 for PR HEAD 30e29e3d4bea4b6e33f792c317e2844942deec8a in total

simonpasquier commented 7 months ago

/retitle OCPBUGS-30257: Making sure proxy settings are correctly forwarded in the generated remote write configs

cloned the original ticket and moved to OCPBUGS so it can be backported if needed.

openshift-ci-robot commented 7 months ago

@Nikokolas3270: This pull request references Jira Issue OCPBUGS-30257, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2269): >Fix some golang mistake in which the `remoteWrite` config objects were copied instead of being passed by reference. >**This may impact the customers as the remote write calls may now be proxied:** >- We may want to fix this issue first: https://github.com/prometheus-operator/prometheus-operator/issues/6301 >- Also it would be nice to have the Prometheus Operator and CMO forward the `noProxy` option on top of the `proxyUrl`; indeed Prometheus is supporting that option: https://github.com/prometheus/prometheus/blob/main/docs/configuration/configuration.md#oauth2 > >c.c. @simonpasquier > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
simonpasquier commented 7 months ago

/hold

we need test case.

jan--f commented 7 months ago

I added a test in #2281 and confirmed this change fixes it. @simonpasquier Are you ok to go ahead with this?

jan--f commented 7 months ago

/retest

Nikokolas3270 commented 7 months ago

@simonpasquier : added a test case.

jan--f commented 7 months ago

/lgtm

jan--f commented 7 months ago

/unhold

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, Nikokolas3270

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [jan--f] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Nikokolas3270 commented 7 months ago

/retest

Nikokolas3270 commented 7 months ago

/retest

jan--f commented 6 months ago

/retest

jan--f commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@jan--f: This pull request references Jira Issue OCPBUGS-30257, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2269#issuecomment-2019507983): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jan--f commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@jan--f: This pull request references Jira Issue OCPBUGS-30257, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2269#issuecomment-2019509528): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

/retest-required

Remaining retests: 0 against base HEAD e761b9ed8656887a0a0820ef09f843e69e4ba0b2 and 2 for PR HEAD c06d26fc52838f25b5e711d8fa9202325f27904b in total

openshift-ci[bot] commented 6 months ago

@Nikokolas3270: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node c06d26fc52838f25b5e711d8fa9202325f27904b link false /test e2e-aws-ovn-single-node
ci/prow/versions c06d26fc52838f25b5e711d8fa9202325f27904b link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 6 months ago

@Nikokolas3270: Jira Issue OCPBUGS-30257: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30257 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2269): >Fix some golang mistake in which the `remoteWrite` config objects were copied instead of being passed by reference. >**This may impact the customers as the remote write calls may now be proxied:** >- We may want to fix this issue first: https://github.com/prometheus-operator/prometheus-operator/issues/6301 >- Also it would be nice to have the Prometheus Operator and CMO forward the `noProxy` option on top of the `proxyUrl`; indeed Prometheus is supporting that option: https://github.com/prometheus/prometheus/blob/main/docs/configuration/configuration.md#oauth2 > >c.c. @simonpasquier > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202403261317.p0.g800bedc.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.

openshift-merge-robot commented 6 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-03-28-223620

jan--f commented 3 months ago

/cherrypick release-4.15

openshift-cherrypick-robot commented 3 months ago

@jan--f: new pull request created: #2413

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2269#issuecomment-2233444955): >/cherrypick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.