MON-3706: Revert "chore: poll immediately in the e2e tests"

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack

Apache License 2.0

247 stars 363 forks source link

MON-3706: Revert "chore: poll immediately in the e2e tests" #2271

Closed simonpasquier closed 7 months ago

simonpasquier commented 7 months ago

This reverts commit 5038186e1c1bf9c86054444310484cc351357f36.

It seems to make the e2e tests very flaky.

[ ] I added CHANGELOG entry for this change.
[ ] No user facing changes, so no entry in CHANGELOG was needed.

machine424 commented 7 months ago

/lgtm

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [machine424,simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

simonpasquier commented 7 months ago

/skip /hold

simonpasquier commented 7 months ago

/retest-required

simonpasquier commented 7 months ago

/retitle MON-3706: Revert "chore: poll immediately in the e2e tests"

openshift-ci-robot commented 7 months ago

@simonpasquier: This pull request references MON-3706 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2271): >This reverts commit 5038186e1c1bf9c86054444310484cc351357f36. > >It seems to make the e2e tests very flaky. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

simonpasquier commented 7 months ago

/hold cancel

The e2e CMO job looks better

simonpasquier commented 7 months ago

/retest-required

openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD 1ffa522529e019e3c559fed6b2a23f1a47ed6a5d and 2 for PR HEAD 10160fd3fefb3791121ad8f5b8bf043938085884 in total

machine424 commented 7 months ago

/retest-required

simonpasquier commented 7 months ago

/retest-required

simonpasquier commented 7 months ago

/retest-required

simonpasquier commented 7 months ago

/skip

simonpasquier commented 7 months ago

/test e2e-aws-ovn-techpreview

machine424 commented 7 months ago

/test e2e-aws-ovn-techpreview

simonpasquier commented 7 months ago

/test e2e-aws-ovn-techpreview

simonpasquier commented 7 months ago

/test e2e-aws-ovn-techpreview

openshift-ci[bot] commented 7 months ago

@simonpasquier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node	10160fd3fefb3791121ad8f5b8bf043938085884	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/versions	10160fd3fefb3791121ad8f5b8bf043938085884	link	false	`/test versions`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

simonpasquier commented 7 months ago

/test e2e-aws-ovn-techpreview

openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202403051609.p0.gb253546.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.