openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

MON-3789: add a golangci-lint-fix makefile target to fix golangci-lint errros when possible #2275

Closed machine424 closed 6 months ago

machine424 commented 7 months ago

…hen possible

machine424 commented 7 months ago

/lgtm althought we could use a small note on the dev docs

I don't see any section about linting, I could take care of that but in another PR.

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [danielmellado,machine424,simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
machine424 commented 7 months ago

/retest

stbenjam commented 6 months ago

/close

stbenjam commented 6 months ago

/reopen

openshift-ci[bot] commented 6 months ago

@stbenjam: Closed this PR.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2275#issuecomment-2021012016): >/close > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
stbenjam commented 6 months ago

/reopen

openshift-ci[bot] commented 6 months ago

@stbenjam: Reopened this PR.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2275#issuecomment-2021014846): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
machine424 commented 6 months ago

/retest

openshift-ci[bot] commented 6 months ago

@machine424: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 39c93cd50ec4118cec6badbf7851ead72a181350 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
machine424 commented 6 months ago

/retitle MON-3789: add a golangci-lint-fix makefile target to fix golangci-lint errros when possible

openshift-ci-robot commented 6 months ago

@machine424: This pull request references MON-3789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2275): >…hen possible > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202404031748.p0.g953011b.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.