search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

build: add -e to fix make generate #2276

Closed marioferh closed 7 months ago

marioferh commented 7 months ago

With new go versions this error apperas:

cluster-monitoring-operator git:(master) make generate                                                                                                     
Installing tools from hack/tools.go                                                                                                                           
tools.go:22:2: import "github.com/brancz/gojsontoyaml" is a program, not an importable package

In order to fix id an -e is added to make generate. Related https://github.com/openshift/cluster-monitoring-operator/pull/2112

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marioferh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 7 months ago

@marioferh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-operator 5342dee811a66e598aeb9a772c8000d82078a8c0 link true /test e2e-agnostic-operator
ci/prow/e2e-aws-ovn-single-node 5342dee811a66e598aeb9a772c8000d82078a8c0 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-techpreview 5342dee811a66e598aeb9a772c8000d82078a8c0 link true /test e2e-aws-ovn-techpreview
ci/prow/versions 5342dee811a66e598aeb9a772c8000d82078a8c0 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).